feat: adding in tag support

[tampajohn]

This PR is the beginning of adding in support for object_tags (https://docs.snowflake.com/en/user-guide/object-tagging.html).

It introduces the snowflake_tag resource which is used to define tags that can then be assigned to other objects within snowflake.

An example of declaring 2 tags, and assigning values for those tags on a table is:

resource "snowflake_tag" "department" {
  name     = "DEPARTMENT"
  schema   = "SOME_SCHEMA"
  database = "SOME_DB"
}

resource "snowflake_tag" "classification" {
  name     = "CLASSIFICATION"
  schema   = "SOME_SCHEMA"
  database = "SOME_DB"
}

resource "snowflake_table" "test_table" {
  schema   = "SOME_SCHEMA"
  database = "SOME_DB"
  name     = "EXAMPLE_TABLE"

  column {
    ...
  }

  tag {
    name     = snowflake_tag.classification.name
    database = snowflake_tag.classification.database
    schema   = snowflake_tag.classification.schema
    value    = "sensitive"
  }

  tag {
    name     = snowflake_tag.department.name
    database = snowflake_tag.department.database
    schema   = snowflake_tag.department.schema
    value    = "marketing"
  }
}

Test Plan

So far tests have been added to both the tag logic in snowflake and resources.

• acceptance tests
• unit tests

References

Addresses issue #702

[tampajohn]

@alldoami As this is my first contribution, I wanted to open this draft up a little early to make sure I'm not going down the wrong path.

I'm going to continue on with adding tag support for various other object types, and possibly in a more generic way (at least for update / drop). My plan is to support tagging on the account, database, and schema level objects, with column support to likely follow in a separate PR.

[alldoami]

make sure to run make docs :D

[tampajohn]

Running make docs now lol... also I think I added support for tags on all objects supporting them just gotta double check the docs...

[alldoami]

/ok-to-test sha=7a09873

[alldoami]

Thanks for being so thorough with testing! 🥳

[tampajohn]

Theres room for more testing on some of the resources... but I know this is a hot issue with some folks...

[github-actions]

Integration tests failure for 7a09873

[alldoami]

/ok-to-test sha=4a8dc58

[github-actions]

Integration tests failure for 4a8dc58

[tampajohn]

I'll rerun these against my account when I get back to my machine.

…

On Wed, 20 Oct 2021, 5:30 pm github-actions[bot], ***@***.***> wrote: Integration tests failure for 4a8dc58 <https://github.com/chanzuckerberg/terraform-provider-snowflake/actions/runs/1365393654> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#713 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5HS4YSZFGO6E3SU5DFJCDUH4YGPANCNFSM5FUHEB4A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[alldoami]

Just request my review again once you've committed these changes 😄

[alldoami]

/ok-to-test sha=41ee8bc

[github-actions]

Integration tests success for 41ee8bc

[tampajohn]

Thank you @alldoami !