Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added Missing Account Privileges #635

Merged
merged 10 commits into from
Aug 12, 2021
Merged

fix: Added Missing Account Privileges #635

merged 10 commits into from
Aug 12, 2021

Conversation

ChrisIsidora
Copy link
Contributor

@ChrisIsidora ChrisIsidora commented Aug 5, 2021 •
edited
Loading

Added missing account privileges and missing view from #634

References

https://docs.snowflake.com/en/user-guide/security-access-control-privileges.html#global-privileges
*

@ChrisIsidora ChrisIsidora requested a review from a team as a code owner August 5, 2021 13:19
@ChrisIsidora ChrisIsidora requested a review from edulop91 August 5, 2021 13:19
@ChrisIsidora ChrisIsidora mentioned this pull request Aug 11, 2021
Closed
@ChrisIsidora
Copy link
Contributor Author

@alldoami Done! I merged #634 in this PR. Can you take a look again? If merged, is it possible to release a new version including these changes? Thanks in advance

@ChrisIsidora ChrisIsidora mentioned this pull request Aug 11, 2021
Merged
2 tasks
@alldoami
Copy link
Contributor

Oops can you fix the conflicts? 😅 I will release a new version after I merge your PR!

@ChrisIsidora
Copy link
Contributor Author

@alldoami Done!

@ChrisIsidora
Copy link
Contributor Author

@alldoami After merging this and updating the branch on #619 , can we check if it's also possible to merge #619 ?

@alldoami
Copy link
Contributor

/ok-to-test sha=ae3f041

@github-actions
Copy link

Integration tests success for ae3f041

@nbob31 nbob31 mentioned this pull request Aug 12, 2021
Closed
@ChrisIsidora
Copy link
Contributor Author

@alldoami Can you check again?

@alldoami alldoami merged commit c9cc806 into Snowflake-Labs:main Aug 12, 2021
@ChrisIsidora ChrisIsidora deleted the feature/add-missing-privileges branch August 12, 2021 21:10
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
@ChrisIsidora @jtzero
fix: Added Missing Account Privileges (Snowflake-Labs#635)
7b187d1
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
@ChrisIsidora @anton-chekanov
fix: Added Missing Account Privileges (Snowflake-Labs#635)
a7acc95
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
@ChrisIsidora
fix: Added Missing Account Privileges (Snowflake-Labs#635)
cae84d4
@snowflake-release-please snowflake-release-please bot mentioned this pull request May 25, 2022
Merged
This was referenced Nov 1, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alldoami alldoami alldoami approved these changes

@edulop91 edulop91 Awaiting requested review from edulop91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisIsidora @alldoami