fix: Fixed Browser PKG #626
Conversation
| github.com/chanzuckerberg/go-misc v0.0.0-20210727205931-6daf95f6727e h1:LyRaq/Sz1omD+bBuVwZBVxAv3qEUHAzgol5IFdG1YtY= | ||
| github.com/chanzuckerberg/go-misc v0.0.0-20210727205931-6daf95f6727e/go.mod h1:mQwH9ExhxX/18odRhummSPc21vJ7TqB5y8u4uYv+1h4= | ||
| github.com/cheggaaa/pb v1.0.27/go.mod h1:pQciLPpbU0oxA0h+VJYYLxO+XeDQb5pZijXscXHm81s= |
There was a problem hiding this comment.
@alldoami Is you run go mod graph you could see that go-misc v0.0.0-20210727205931-6daf95f6727e added the browser dependency that is breaking the release?
There was a problem hiding this comment.
Could you explain how this works for future reference 😅
There was a problem hiding this comment.
@alldoami I also don't know. All I know is that when the go mods where updated the go-misc mod of chanzuckerberg was also updated and in the new updated version it's pulling a new version of the indirect dependency browser pkg which broke the release. Using go mod graph you can find out where the indirect dependency is coming from, which in this case was flgo-misc
|
/ok-to-test sha=c0bb8c1 |
|
Integration tests success for c0bb8c1 |
|
Thanks so much @ChrisIsidora ! |
Attempt to fix #624 (comment)