Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade tf for testing #625

Merged
merged 13 commits into from
Jul 30, 2021
Merged

fix: Upgrade tf for testing #625

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
82ac5bf
fix: Upgrade tf for testing
alldoami Jul 29, 2021
8b6bfa1
update readme
alldoami Jul 29, 2021
aaa8cb7
period
alldoami Jul 29, 2021
622c326
make deps
alldoami Jul 29, 2021
ebb8349
update go files
alldoami Jul 29, 2021
b6f3596
gotidy and fix version string
jakeyheath Jul 29, 2021
529c23c
empty
alldoami Jul 29, 2021
afab646
revert go.mod
jakeyheath Jul 29, 2021
f17f84f
Merge branch 'adoami/upgrade-tf-for-testing' of github.com:chanzucker…
jakeyheath Jul 29, 2021
b0b12d5
revert go.sum
jakeyheath Jul 29, 2021
ac2e13e
empty
alldoami Jul 29, 2021
0b54ac4
go get -u
alldoami Jul 29, 2021
4b1b863
fixes
alldoami Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export DIRTY=$(shell if `git diff-index --quiet HEAD --`; then echo false; else
LDFLAGS=-ldflags "-w -s -X github.com/chanzuckerberg/go-misc/ver.GitSha=${SHA} -X github.com/chanzuckerberg/go-misc/ver.Version=${VERSION} -X github.com/chanzuckerberg/go-misc/ver.Dirty=${DIRTY}"
export BASE_BINARY_NAME=terraform-provider-snowflake_v$(VERSION)
export GO111MODULE=on
export TF_ACC_TERRAFORM_VERSION=0.12.29
export TF_ACC_TERRAFORM_VERSION=0.13
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add the readme that there's now a version requirement for the provider

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alldoami @edulop91 I think this is failing because it should be 0.13.x in this case 0.13.0 not only 0.13

export SKIP_EXTERNAL_TABLE_TESTS=true

go_test ?= -
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ You can also just download a binary from our [releases](https://github.com/chanz

### For Terraform v0.13+ users

> We are now (7/29/2021) using Terraform 0.13 for testing purposes due to an issue for data sources for versions <0.13. Related PR for this change [here](https://github.com/chanzuckerberg/terraform-provider-snowflake/pull/622#issuecomment-888879621).

You can use [Explicit Provider Source Locations](https://www.terraform.io/upgrade-guides/0-13.html#explicit-provider-source-locations).

The following maybe work well.
Expand Down
49 changes: 41 additions & 8 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,57 @@ module github.com/chanzuckerberg/terraform-provider-snowflake
go 1.15

require (
github.com/Azure/azure-storage-blob-go v0.14.0 // indirect
github.com/CloudyKit/jet v2.1.3-0.20180809161101-62edd43e4f88+incompatible // indirect
github.com/DATA-DOG/go-sqlmock v1.5.0
github.com/Joker/jade v1.0.1-0.20190614124447-d475f43051e7 // indirect
github.com/Pallinder/go-randomdata v1.2.0
github.com/agext/levenshtein v1.2.3 // indirect
github.com/agl/ed25519 v0.0.0-20170116200512-5312a6153412 // indirect
github.com/apache/arrow/go/arrow v0.0.0-20210729014410-9b09c6c44bb0 // indirect
github.com/apparentlymart/go-cidr v1.1.0 // indirect
github.com/armon/go-radix v1.0.0 // indirect
github.com/aws/aws-sdk-go v1.37.0 // indirect
github.com/chanzuckerberg/go-misc v0.0.0-20201208181439-ea3e3e39e194
github.com/hashicorp/hcl/v2 v2.8.2 // indirect
github.com/hashicorp/terraform-exec v0.13.3 // indirect
github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.3.2 // indirect
github.com/chanzuckerberg/go-misc v0.0.0-20210727205931-6daf95f6727e
github.com/fatih/color v1.12.0 // indirect
github.com/flosch/pongo2 v0.0.0-20190707114632-bbf5a6c351f4 // indirect
github.com/form3tech-oss/jwt-go v3.2.3+incompatible // indirect
github.com/golang/snappy v0.0.4 // indirect
github.com/google/uuid v1.3.0 // indirect
github.com/gruntwork-io/gruntwork-cli v0.5.1 // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
github.com/hashicorp/go-hclog v0.16.2 // indirect
github.com/hashicorp/go-plugin v1.4.2 // indirect
github.com/hashicorp/go-uuid v1.0.2 // indirect
github.com/hashicorp/hcl/v2 v2.10.1 // indirect
github.com/hashicorp/terraform-plugin-docs v0.4.0
github.com/hashicorp/terraform-plugin-sdk/v2 v2.4.4
github.com/jmoiron/sqlx v1.3.1
github.com/hashicorp/terraform-plugin-go v0.3.1 // indirect
github.com/hashicorp/terraform-plugin-sdk/v2 v2.7.0
github.com/hashicorp/yamux v0.0.0-20210707203944-259a57b3608c // indirect
github.com/iris-contrib/i18n v0.0.0-20171121225848-987a633949d0 // indirect
github.com/jmoiron/sqlx v1.3.4
github.com/keybase/go-crypto v0.0.0-20161004153544-93f5b35093ba // indirect
github.com/luna-duclos/instrumentedsql v1.1.3
github.com/mattn/go-isatty v0.0.13 // indirect
github.com/mediocregopher/mediocre-go-lib v0.0.0-20181029021733-cb65787f37ed // indirect
github.com/mitchellh/go-homedir v1.1.0
github.com/mitchellh/go-testing-interface v1.14.1 // indirect
github.com/mitchellh/go-wordwrap v1.0.1 // indirect
github.com/mitchellh/mapstructure v1.4.1 // indirect
github.com/oklog/run v1.1.0 // indirect
github.com/pkg/browser v0.0.0-20210706143420-7d21f8c997e2 // indirect
github.com/pkg/errors v0.9.1
github.com/posener/complete v1.2.1 // indirect
github.com/snowflakedb/gosnowflake v1.4.1
github.com/pquerna/cachecontrol v0.0.0-20200819021114-67c6ae64274f // indirect
github.com/snowflakedb/gosnowflake v1.6.0
github.com/stretchr/testify v1.7.0
golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2
github.com/svanharmelen/jsonapi v0.0.0-20180618144545-0c0828c3f16d // indirect
github.com/zclconf/go-cty v1.9.0 // indirect
golang.org/x/crypto v0.0.0-20210711020723-a769d52b0f97
golang.org/x/tools v0.1.5
google.golang.org/api v0.34.0 // indirect
google.golang.org/appengine v1.6.7 // indirect
google.golang.org/genproto v0.0.0-20210729151513-df9385d47c1b // indirect
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
sigs.k8s.io/structured-merge-diff/v3 v3.0.0 // indirect
)
Loading