Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the use of schema in show file formats #600

Merged
merged 4 commits into from
Jul 13, 2021

Conversation

yonieilon
Copy link
Contributor

use SCHEMA instead of DATABASE in show for file formats.
Addresses #594

Test Plan

Current tests pass...

References

https://docs.snowflake.com/en/sql-reference/sql/show-file-formats.html (note use of SCHEMA or DATABASE)

@yonieilon yonieilon requested a review from a team as a code owner July 11, 2021 06:37
@yonieilon yonieilon requested a review from edulop91 July 11, 2021 06:37
@yonieilon yonieilon changed the title use schema in show file formats fix the use of schema in show file formats Jul 11, 2021
@yonieilon yonieilon changed the title fix the use of schema in show file formats [fix] the use of schema in show file formats Jul 11, 2021
@yonieilon yonieilon closed this Jul 11, 2021
@yonieilon yonieilon reopened this Jul 11, 2021
@yonieilon yonieilon changed the title [fix] the use of schema in show file formats fix: the use of schema in show file formats Jul 12, 2021
@yonieilon
Copy link
Contributor Author

Hi @edulop91 , have you had a chance to look at this PR?

Thanks.

@edulop91
Copy link

/ok-to-test sha=f21d840

@github-actions
Copy link

Integration tests success for f21d840

@alldoami
Copy link
Contributor

/ok-to-test sha=9ddd58c

@github-actions
Copy link

Integration tests success for 9ddd58c

@alldoami alldoami merged commit 0f433c5 into Snowflake-Labs:main Jul 13, 2021
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants