feat: Add a resource to manage sequences #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfedde
changed the title
alldoami
reviewed
Jun 21, 2021
|
I'm not totally familiar with sequences, but should we try and provide a |
|
/ok-to-test sha=c983e34 |
|
Integration tests success for c983e34 |
|
We could add a start but it is a little confusing on how to implement it. It is only useful on create. On an update we don't want to regress the counter back to its start. We would also need to be smart in the cases where the sequence is recreated. I was unable to figure out a way to implement it so that it would be obvious what would happen if it was used so I left it out. |
|
@dfedde cool, wanna update your branch and commit the change I suggested above? |
Addresses feature-request Snowflake-Labs#509
|
/ok-to-test sha=4f30f92 |
|
Integration tests success for 4f30f92 |
alldoami
approved these changes
Jun 23, 2021
jtzero
pushed a commit
to rxrevu/terraform-provider-snowflake
that referenced
this pull request
Aug 19, 2021
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feature-request #509
Test Plan
References