Lower limit on warehouse auto-suspend setting #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test sha=ae6466f |
|
Integration tests success for ae6466f |
|
Thank you! |
jtzero
pushed a commit
to rxrevu/terraform-provider-snowflake
that referenced
this pull request
Aug 19, 2021
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warehouse auto-suspend setting can actually be an arbitrary integer (you can test this with
alter warehouse reporting set auto_suspend = <x>). The current check for 60 seconds imposes an arbitrary restriction on the provider that's not present in the service.Negative values are just interpreted as "never". Based on the intent of the provider surface it looks like the "never" case should be handled by removing the auto-suspend setting, so a 1-second minimum seemed reasonable.