Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ok-to-test: Add job result to status comment #414

Merged
merged 4 commits into from
Jan 14, 2021

Conversation

edulop91
Copy link

Instead of appending all integration tests comments, replace old comments (GH still preserves comment history). Furthermore, add the job result to the comment.

Test Plan

  • acceptance tests

References

@edulop91 edulop91 requested a review from a team as a code owner January 14, 2021 18:16
@edulop91 edulop91 requested a review from alldoami January 14, 2021 18:16
@github-actions
Copy link

Integration tests success for a0f956e5c3a38731033b4d65e49a4d7f81ff04cf

@edulop91 edulop91 requested a review from ryanking January 14, 2021 18:25
@github-actions
Copy link

Integration tests success for d424a815b95a20b874d0a09ed09f8c8329705589

@edulop91 edulop91 changed the title [fix] ok-to-test: Replace job run comments, add status [fix] ok-to-test: Add job result to status comment Jan 14, 2021
@github-actions
Copy link

Integration tests success for 2f1f5d5a70c711aad7b36bf32fe2a9b76a657e37

@github-actions
Copy link

Integration tests success for f90c2958aaa3cec299364c75fa725b4dfe038605

@czimergebot czimergebot merged commit eed3f10 into main Jan 14, 2021
@czimergebot czimergebot deleted the edu/integration-test-comment branch January 14, 2021 19:43
gjv9491 pushed a commit to gjv9491/terraform-provider-snowflake that referenced this pull request Mar 19, 2021
<!-- Feel free to delete comments as you fill this in -->
Instead of appending all integration tests comments, replace old comments (GH still preserves comment history). Furthermore, add the job result to the comment.

<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->

*
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
<!-- Feel free to delete comments as you fill this in -->
Instead of appending all integration tests comments, replace old comments (GH still preserves comment history). Furthermore, add the job result to the comment.

<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->

*
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
<!-- Feel free to delete comments as you fill this in -->
Instead of appending all integration tests comments, replace old comments (GH still preserves comment history). Furthermore, add the job result to the comment.

<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->

*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants