Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: NO-SNOW add examples for stage's file_format from #265 #3319

Merged
merged 11 commits into from
Jan 9, 2025
Merged

docs: NO-SNOW add examples for stage's file_format from #265 #3319

merged 11 commits into from
Jan 9, 2025

Conversation

sfc-gh-dszmolka
Copy link
Collaborator

Description

Doc-only change, no code was changed.
This PR aims to lessen the confusion around how to specify file_format for the Stage resource, as people were hitting it in the past. Thanks to the contribution from the community - making the various example part of resource docs for finding it easier.

References

closes #265

@sfc-gh-dszmolka sfc-gh-dszmolka changed the title add examples for stage's file_format from #265 docs: add examples for stage's file_format from #265 Dec 26, 2024
@github-actions GitHub Actions
Copy link

Integration tests cancelled for c17d7794d4ac21d54fd1db33ec2eb325fd699c39

@github-actions GitHub Actions
Copy link

Integration tests cancelled for a3dcd9c305859c311d61ad69d5cea176e4163871

@github-actions GitHub Actions
Copy link

Integration tests cancelled for 8551c9723a3460e28821578bba7d638564f17d3b

@github-actions GitHub Actions
Copy link

Integration tests cancelled for 6dc4b60db1d201dda82ec6facec88b582025942c

@github-actions GitHub Actions
Copy link

Integration tests cancelled for 590aecb174ceb1f162f585e1c5d6b9ddba2ac152

@github-actions GitHub Actions
Copy link

Integration tests failure for f21c49cefb458876a9e7760001cd0efe66cb629f

@github-actions GitHub Actions
Copy link

Integration tests cancelled for c30314e09fea39be61604e24509e6b71ab983286

@github-actions GitHub Actions
Copy link

Integration tests cancelled for 3c151554abfb88b382b52ed3ac148eceef09ba1b

sfc-gh-jmichalak
sfc-gh-jmichalak requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resource will be reworked, and I suppose file_format will be affected as well. But I agree we can improve the docs for now.

pkg/resources/stage.go Outdated Show resolved Hide resolved
@sfc-gh-jmichalak sfc-gh-jmichalak mentioned this pull request Jan 7, 2025
Merged
sfc-gh-asawicki
sfc-gh-asawicki reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @sfc-gh-jmichalak comment, otherwise LGTM

sfc-gh-dszmolka and others added 2 commits January 8, 2025 13:42
@sfc-gh-dszmolka
incorporated review advice:
2eba438 
* added example in resource.tf (for snwoflake_stage)
* using the preferred format for dynamic value in stage.go
@sfc-gh-dszmolka
Merge branch 'dev' into NO-SNOW-extend-docs-for-file-format
35db31f
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title docs: add examples for stage's file_format from #265 docs: NO-SNOW add examples for stage's file_format from #265 Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Integration tests failure for 2eba438d4f3727451424edbd3d66e45d89d9801b

@sfc-gh-dszmolka
Copy link
Collaborator Author

@sfc-gh-jmichalak review has been addressed, but merging is blocked due to the 'changes requested' state. Can you please re-review ? Thank you in advance !

@sfc-gh-dszmolka sfc-gh-dszmolka enabled auto-merge (squash) January 9, 2025 11:02
@sfc-gh-dszmolka sfc-gh-dszmolka merged commit 25323da into dev Jan 9, 2025
8 of 9 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the NO-SNOW-extend-docs-for-file-format branch January 9, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak Awaiting requested review from sfc-gh-jcieslak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dszmolka @sfc-gh-asawicki @sfc-gh-jmichalak