Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tasks v1 readiness part3 #3202

Merged
merged 3 commits into from
Nov 25, 2024
Merged

feat: Tasks v1 readiness part3 #3202

merged 3 commits into from
Nov 25, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Nov 14, 2024 •
edited
Loading

@sfc-gh-jcieslak sfc-gh-jcieslak changed the base branch from main to tasks-v1-readiness November 14, 2024 14:09
This was referenced Nov 14, 2024
Merged
Merged
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the tasks-v1-readiness-part3 branch from bfb6ad7 to 6e67976 Compare November 20, 2024 15:00
@github-actions GitHub Actions
Copy link

Integration tests failure for 6e6797665fade52bcc7291e984122477fdf28951

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review November 20, 2024 15:05
@github-actions GitHub Actions
Copy link

Integration tests failure for 6e6797665fade52bcc7291e984122477fdf28951

@github-actions GitHub Actions
Copy link

Integration tests failure for bbba62e318a8b5d13a86469ac4dfe0b24a0af205

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the tasks-v1-readiness-part3 branch from bbba62e to dcc89cd Compare November 20, 2024 15:52
@github-actions GitHub Actions
Copy link

Integration tests failure for dcc89cdf3b2fb0d97b34839ccc3f347c9a0a43cc

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 21, 2024 18:21
sfc-gh-asawicki
sfc-gh-asawicki requested changes Nov 21, 2024
View reviewed changes
pkg/resources/task.go Show resolved Hide resolved
pkg/resources/task.go Outdated Show resolved Hide resolved
pkg/resources/task_state_upgraders.go Outdated Show resolved Hide resolved
pkg/resources/task_state_upgraders.go Show resolved Hide resolved
pkg/resources/task_state_upgraders.go Outdated Show resolved Hide resolved
pkg/sdk/tasks_gen_test.go Show resolved Hide resolved
pkg/resources/task_acceptance_test.go Show resolved Hide resolved
pkg/resources/task_acceptance_test.go Outdated Show resolved Hide resolved
pkg/resources/task_acceptance_test.go Show resolved Hide resolved
pkg/resources/task_acceptance_test.go Show resolved Hide resolved
sfc-gh-jmichalak
sfc-gh-jmichalak requested changes Nov 22, 2024
View reviewed changes
pkg/sdk/tasks_gen.go Outdated Show resolved Hide resolved
pkg/sdk/tasks_gen_test.go Outdated Show resolved Hide resolved
pkg/sdk/tasks_gen_test.go Outdated Show resolved Hide resolved
pkg/resources/task.go
Type: schema.TypeString,
Optional: true,
DiffSuppressFunc: IgnoreChangeToCurrentSnowflakeValueInShow("config"),
Description: "Specifies a string representation of key value pairs that can be accessed by all tasks in the task graph. Must be in JSON format.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add it to the config that $$ is added automatically?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, does it matter what happens underneath on such low level? I'm not sure, I would say the most important info is that the accepted format should be in JSON.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But someone may think that it needs to be wrapped in $$, and then the config would be double-wrapped, right?

pkg/resources/task_acceptance_test.go Show resolved Hide resolved
pkg/resources/task_acceptance_test.go Show resolved Hide resolved
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 22, 2024 15:22
@github-actions GitHub Actions
Copy link

Integration tests failure for c03f171dcb2730b11456cb0e548406c403f9cfa4

@github-actions GitHub Actions
Copy link

Integration tests failure for 02245594c3997fe1e14fba76537526ee456dc60c

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 57e99f4 into tasks-v1-readiness Nov 25, 2024
9 of 10 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the tasks-v1-readiness-part3 branch November 25, 2024 12:26
@sfc-gh-jcieslak sfc-gh-jcieslak mentioned this pull request Nov 25, 2024
Merged
sfc-gh-jcieslak added a commit that referenced this pull request Nov 26, 2024
@sfc-gh-jcieslak
feat: Tasks v1 readiness (#3222)
e2284d9 
Pr that collects all the changes to tasks from previous prs:
-
#3202
-
#3170
-
#3113

**Note**: look at the last commit, added very small changes to
documentation and code (around 8 lines)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jcieslak @sfc-gh-asawicki @sfc-gh-jmichalak