feat: Secrets datasource

docs/data-sources/secrets.md

@@ -43,7 +43,7 @@ output "like_prefix_output" {
 # Filtering (in)
 data "snowflake_secrets" "in" {
   in {
-    schema = "schema_fully_qualified_name"
+    schema = "snowflake_schema.test.fully_qualified_name"
   }
 }
 

examples/data-sources/snowflake_secrets/data-source.tf

@@ -27,7 +27,7 @@ output "like_prefix_output" {
 # Filtering (in)
 data "snowflake_secrets" "in" {
   in {
-    schema = "schema_fully_qualified_name"
+    schema = "snowflake_schema.test.fully_qualified_name"
   }
 }
 

pkg/datasources/secrets.go

@@ -104,15 +104,15 @@ func Secrets() *schema.Resource {
 
 func ReadSecrets(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {
 	client := meta.(*provider.Context).Client
-	req := *sdk.NewShowSecretRequest()
+	req := sdk.NewShowSecretRequest()
 
 	handleLike(d, &req.Like)
 	err := handleExtendedIn(d, &req.In)
 	if err != nil {
 		return diag.FromErr(err)
 	}
 
-	secrets, err := client.Secrets.Show(ctx, &req)
+	secrets, err := client.Secrets.Show(ctx, req)
 	if err != nil {
 		return diag.FromErr(err)
 	}

pkg/datasources/secrets_acceptance_test.go

@@ -240,15 +240,6 @@ func TestAcc_Secrets_Filtering(t *testing.T) {
 	)
 	t.Cleanup(apiIntegrationCleanup)
 
-	// ERROR Insufficient privileges to operate on account ... for role BASIC_PRIVILEGES
-	/*
-		appPkg, appPkgCleanup := acc.TestClient().ApplicationPackage.CreateApplicationPackage(t)
-		t.Cleanup(appPkgCleanup)
-
-		_, appCleanup := acc.TestClient().Application.CreateApplication(t, appPkg.ID(), "1")
-		t.Cleanup(appCleanup)
-	*/
-
 	schema, schemaCleanup := acc.TestClient().Schema.CreateSchemaInDatabase(t, acc.TestClient().Ids.DatabaseId())
 	t.Cleanup(schemaCleanup)
 
@@ -307,32 +298,13 @@ func TestAcc_Secrets_Filtering(t *testing.T) {
 					resource.TestCheckResourceAttr("data.snowflake_secrets.test", "secrets.#", "5"),
 				),
 			},
-			/*
-				// In Application Package
-				// ERROR Insufficient privileges to operate on account ... for role BASIC_PRIVILEGES
-				{
-					Config: multipleSecretModels + secretDatasourceWithIn("application_package", idFive.DatabaseId().FullyQualifiedName()),
-					Check: resource.ComposeTestCheckFunc(
-						resource.TestCheckResourceAttr("data.snowflake_secrets.test", "secrets.#", "5"),
-					),
-				},
-				// In Application
-				// ERROR Insufficient privileges to operate on account ... for role BASIC_PRIVILEGES
-				{
-					Config: multipleSecretModels + secretDatasourceWithIn("application", idFive.DatabaseId().FullyQualifiedName()),
-					Check: resource.ComposeTestCheckFunc(
-						resource.TestCheckResourceAttr("data.snowflake_secrets.test", "secrets.#", "5"),
-					),
-				},
-				// In Account
-				// ERROR Insufficient privileges to operate on 'SYSTEM' for role BASIC_PRIVILEGES
-					{
-						Config: multipleSecretModels + secretDatasourceWithIn("account", acc.TestClient().Account.GetAccountIdentifier(t).FullyQualifiedName()),
-						Check: resource.ComposeTestCheckFunc(
-							resource.TestCheckResourceAttr("data.snowflake_secrets.test", "secrets.#", "5"),
-						),
-					},
-			*/
+			// In Account
+			{
+				Config: multipleSecretModels + secretDatasourceInAccountWithLike(prefix+"%"),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("data.snowflake_secrets.test", "secrets.#", "3"),
+				),
+			},
 		},
 	})
 }
@@ -356,6 +328,18 @@ func secretDatasourceWithIn(objectName, objectFullyQualifiedName string) string
 `, objectName, strings.ReplaceAll(objectFullyQualifiedName, `"`, ""))
 }
 
+func secretDatasourceInAccountWithLike(prefix string) string {
+	return fmt.Sprintf(`
+    data "snowflake_secrets" "test" {
+        depends_on = [snowflake_secret_with_basic_authentication.s, snowflake_secret_with_generic_string.s2, snowflake_secret_with_client_credentials.s3, snowflake_secret_with_authorization_code_grant.s4]
+        in {
+            account = true
+        }
+        like = "%s"
+    }
+`, prefix)
+}
+
 func TestAcc_Secrets_EmptyIn(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		ProtoV6ProviderFactories: acc.TestAccProtoV6ProviderFactories,