feat: Add secret to sdk #3091

sfc-gh-fbudzynski · 2024-09-19T09:02:16Z

Changes

Changed name of Secret struct in common_types.go due to naming clash
Added Secret Object to SDK
Unit and integration tests

References

CREATE SECRET

github-actions · 2024-09-19T10:42:02Z

Integration tests failure for 01a70062a3b2aed8351229d43d94e520ec3c1e05

github-actions · 2024-09-19T11:16:54Z

Integration tests failure for 929c810a42e5eade5724b107bb10432ed35e376b

github-actions · 2024-09-19T13:31:10Z

Integration tests failure for 8c5dcfb3ad8ad5d7394d32c8c8f6896697c5e498

pkg/acceptance/helpers/secret_client.go

pkg/sdk/secrets_def.go

pkg/sdk/testint/secrets_gen_integration_test.go

sfc-gh-jmichalak

Overall a good first PR 👍

pkg/acceptance/helpers/secret_client.go

pkg/sdk/secrets_def.go

pkg/sdk/testint/secrets_gen_integration_test.go

pkg/sdk/secrets_gen.go

pkg/sdk/testint/secrets_gen_integration_test.go

…aming clash

github-actions · 2024-09-24T09:56:07Z

Integration tests failure for 4ccc4e7c6e391151251af148c4f0d03d559d2344

pkg/sdk/secrets_gen_integration_test.go

pkg/sdk/secrets_validations_gen.go

pkg/sdk/testint/secrets_gen_integration_test.go

…validationType

github-actions · 2024-09-24T14:22:46Z

Integration tests failure for bdf2585574da6c6a5f77546015d0d107907aae1b

github-actions · 2024-09-25T10:09:12Z

Integration tests failure for 7791f33dae8de262967283156065ac9cee49972e

pkg/sdk/testint/secrets_gen_integration_test.go

… creation and alter set

pkg/sdk/secrets_gen_test.go

github-actions · 2024-09-30T14:14:19Z

Integration tests failure for 0e181360fceab0b55bdadc37a4822102200908d4

github-actions · 2024-09-30T15:59:58Z

Integration tests failure for a18b8f59fb9a22f523103e577aefe35cddf90835

# Conflicts: # pkg/acceptance/bettertestspoc/assert/objectassert/gen/sdk_object_def.go

github-actions · 2024-10-01T10:11:16Z

Integration tests failure for 22e809e0ae065fd1a4c644467cad5d6989d683c9

sfc-gh-asawicki · 2024-10-02T19:53:21Z

pkg/sdk/secrets_gen_test.go

+		assertOptsInvalidJoinedErrors(t, opts, errExactlyOneOf("AlterSecretOptions", "Set", "Unset"))
+	})
+
+	t.Run("validation: conflicting fields for [opts.Set.SetForOAuthClientCredentialsFlow opts.Set.SetForOAuthAuthorizationFlow opts.Set.SetForBasicAuthentication opts.Set.SetForGenericString]", func(t *testing.T) {


nit-pick: in such cases we usually have two tests: 1. with no value set 2. with at least two values set

sfc-gh-asawicki · 2024-10-02T19:56:31Z

pkg/sdk/testint/secrets_gen_integration_test.go

+
+	integrationId := testClientHelper().Ids.RandomAccountObjectIdentifier()
+
+	// "YYYY-MM-DD" or "YYYY-MM-DD HH-MI-SS" format has to be used, otherwise Snowflake returns error: "Invalid date/time format"


instead of such a comment we can document this as a test (wrong format passed -> error expected)

ok, will do the tests for such cases next time, or I will try to add them with the next PRs

sfc-gh-asawicki · 2024-10-02T19:59:20Z

pkg/sdk/testint/secrets_gen_integration_test.go

+	)
+	t.Cleanup(apiIntegrationCleanup)
+
+	stringDateToSnowflakeTimeFormat := func(inputLayout, date string) *time.Time {


this method works for our test accounts with location set to "America/Los_Angeles" but will fail if account in any other location is used, right?

I'm not sure, but i think that it would fail. If there is a way to change location of the account then it would be nice to test it and ultimately change the test so it won't depend on account location somehow.

pkg/sdk/testint/secrets_gen_integration_test.go

sfc-gh-asawicki · 2024-10-02T20:03:20Z

pkg/sdk/testint/secrets_gen_integration_test.go

+		})
+	})
+
+	// regarding the https://docs.snowflake.com/en/sql-reference/sql/create-secret secret with empty oauth_scopes list should inherit scopes from security_integration, but it does not


here and in the previous test - if it does not, then it is a SNowflake problem that should be revisited in the future, right? In such cases we should leave a TODO with issue number assigned.

🤖 I have created a release *beep* *boop* --- ## [0.97.0](v0.96.0...v0.97.0) (2024-10-10) ### 🎉 **What's new:** * Add secret to sdk ([#3091](#3091)) ([7430aee](7430aee)) * Add service user and legacy service user resources ([#3119](#3119)) ([0e88e08](0e88e08)) * Handle all Task parameters in SDK ([#3103](#3103)) ([08ae072](08ae072)) * Stream on external table resource ([#3122](#3122)) ([d837341](d837341)) * Stream on table resource ([#3109](#3109)) ([97fa9b4](97fa9b4)) * Tasks v1 readiness - SDK part ([#3086](#3086)) ([0a77383](0a77383)) * Upgrade stream sdk ([#3105](#3105)) ([ad5fa11](ad5fa11)) ### 🔧 **Misc** * Add pre check to each datasource ([#3065](#3065)) ([560ab6b](560ab6b)) * Bump golang-ci lint to 1.61 ([#3112](#3112)) ([f23e085](f23e085)) * Secret Validation change ([#3111](#3111)) ([666630e](666630e)) ### 🐛 **Bug fixes:** * Fix parsing text in view, check parenthesis in ParseSchemaObjectIdentifierWithArguments ([#3102](#3102)) ([b0a67e6](b0a67e6)) * Try to reproduce 2679 and 3117 ([#3124](#3124)) ([ccdbc30](ccdbc30)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

sfc-gh-fbudzynski force-pushed the add-secret-to-sdk branch from 929c810 to 8c5dcfb Compare September 19, 2024 11:43

sfc-gh-fbudzynski requested review from sfc-gh-jcieslak and sfc-gh-jmichalak September 19, 2024 12:05

sfc-gh-fbudzynski marked this pull request as ready for review September 19, 2024 12:12

sfc-gh-jcieslak reviewed Sep 20, 2024

View reviewed changes

sfc-gh-jmichalak requested changes Sep 20, 2024

View reviewed changes

sfc-gh-fbudzynski added 21 commits September 24, 2024 10:14

initial secret_def file for sdk

58d5794

naming changes to secret create options

f1488ca

create secrets and alter with two basic tests

752f924

unit tests for alter

d7ae12f

add tests for all four create types

57ca19a

rename previous secret to secretReference in common_types.go due to n…

8d55a63

…aming clash

secrets gen with drop, show and desc

9894799

all unit tests

e4a0827

init for integration tests

3bb8c85

added secret to client.go and created secret_client

4130618

added like and in to showByID for secret

fc85c66

init for integration tests

aa64511

secret_def changes

ab8bee1

tests for two methods of creating secret

3541c70

changed refresh token expiry time from string to time.Time

180a7ce

added remaining integration tests

7a9ad92

linter

0e9cf94

linting

deadc65

removing comment

235fbe5

mid review commit before generating assertions

73eeb63

rebase conflict resolved

bd0b64f

sfc-gh-jcieslak reviewed Sep 24, 2024

View reviewed changes

sfc-gh-fbudzynski added 2 commits September 24, 2024 14:40

updated generator README with validation issue for ConflictingFields …

34983af

…validationType

updated after re-review

bdf2585

sfc-gh-jcieslak previously approved these changes Sep 25, 2024

View reviewed changes

test changed to use errMoreThanOneOf

7791f33

sfc-gh-fbudzynski dismissed sfc-gh-jcieslak’s stale review via 7791f33 September 25, 2024 08:27

sfc-gh-jmichalak reviewed Sep 30, 2024

View reviewed changes

pkg/sdk/testint/secrets_gen_integration_test.go Outdated Show resolved Hide resolved

sfc-gh-fbudzynski added 2 commits September 30, 2024 14:32

Wrapped OAuth Scopes in separate queryStructField to allow empty list…

d3e54db

… creation and alter set

Linter adjustments

0e18136

sfc-gh-jmichalak previously approved these changes Sep 30, 2024

View reviewed changes

sfc-gh-jcieslak reviewed Sep 30, 2024

View reviewed changes

pkg/sdk/secrets_gen_test.go Outdated Show resolved Hide resolved

errMoreThanOneOf change to be proper errOneOf

a18b8f5

sfc-gh-fbudzynski dismissed sfc-gh-jmichalak’s stale review via a18b8f5 September 30, 2024 14:03

readme known issues more verbose description of the issue

bbd7b7a

sfc-gh-jcieslak previously approved these changes Oct 1, 2024

View reviewed changes

Merge branch 'main' into add-secret-to-sdk

22e809e

# Conflicts: # pkg/acceptance/bettertestspoc/assert/objectassert/gen/sdk_object_def.go

sfc-gh-fbudzynski dismissed sfc-gh-jcieslak’s stale review via 22e809e October 1, 2024 08:17

sfc-gh-fbudzynski requested a review from sfc-gh-jcieslak October 1, 2024 08:21

sfc-gh-jcieslak approved these changes Oct 1, 2024

View reviewed changes

sfc-gh-fbudzynski merged commit 7430aee into main Oct 1, 2024
8 of 9 checks passed

sfc-gh-fbudzynski deleted the add-secret-to-sdk branch October 1, 2024 11:10

snowflake-release-please bot mentioned this pull request Sep 30, 2024

chore(main): release 0.97.0 #3100

Merged

sfc-gh-asawicki reviewed Oct 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add secret to sdk #3091

feat: Add secret to sdk #3091

sfc-gh-fbudzynski commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

sfc-gh-jmichalak left a comment

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

sfc-gh-asawicki Oct 2, 2024

sfc-gh-asawicki Oct 2, 2024

sfc-gh-fbudzynski Oct 3, 2024

sfc-gh-asawicki Oct 2, 2024

sfc-gh-fbudzynski Oct 3, 2024

sfc-gh-asawicki Oct 2, 2024


		integrationId := testClientHelper().Ids.RandomAccountObjectIdentifier()

		// "YYYY-MM-DD" or "YYYY-MM-DD HH-MI-SS" format has to be used, otherwise Snowflake returns error: "Invalid date/time format"

feat: Add secret to sdk #3091

feat: Add secret to sdk #3091

Conversation

sfc-gh-fbudzynski commented Sep 19, 2024 • edited Loading

Changes

References

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

sfc-gh-jmichalak left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

sfc-gh-asawicki Oct 2, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Oct 2, 2024

Choose a reason for hiding this comment

sfc-gh-fbudzynski Oct 3, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Oct 2, 2024

Choose a reason for hiding this comment

sfc-gh-fbudzynski Oct 3, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Oct 2, 2024

Choose a reason for hiding this comment

sfc-gh-fbudzynski commented Sep 19, 2024 •

edited

Loading