feat: Add SDK for External Volumes #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdoldis
commented
Sep 3, 2024
| comment := "some comment" | ||
| id := createExternalVolume( | ||
| t, | ||
| append(append(append(append(s3StorageLocations, gcsStorageLocationsNoEncryption...), azureStorageLocations...), s3StorageLocationsNoEncryption...), gcsStorageLocations...), |
There was a problem hiding this comment.
Once version 1.22 is available Slices.Concat can be used, which will clean these lines up a bit
jdoldis
commented
Sep 3, 2024
| client := testClient(t) | ||
| ctx := testContext(t) | ||
|
|
||
| awsBaseUrl := testenvs.GetOrSkipTest(t, testenvs.AwsExternalBucketUrl) |
There was a problem hiding this comment.
Not exactly sure what these evaluate to on your side. The formats I was using locally -
TEST_SF_TF_AWS_EXTERNAL_BUCKET_URL=s3://my_example_bucket
TEST_SF_TF_AWS_EXTERNAL_KEY_ID=1234abcd-12ab-34cd-56ef-1234567890ab
TEST_SF_TF_AWS_EXTERNAL_ROLE_ARN=arn:aws:iam::123456789012:role/myrole
TEST_SF_TF_GCS_EXTERNAL_BUCKET_URL=gcs://my_example_bucket
TEST_SF_TF_AZURE_EXTERNAL_BUCKET_URL=azure://123456789.blob.core.windows.net/my_example_container
TEST_SF_TF_AZURE_EXTERNAL_TENANT_ID=123456789
sfc-gh-asawicki
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Good change!
I checked it and left mostly cosmetic comments. I also left a few pointers for the future contributions :)
Let's wait for @sfc-gh-jcieslak review too (it will happen tomorrow morning).
After that, I think we will run it to check the test results.
…t opts.AddStorageLocation] should be present - zero set
|
Thanks for the review @sfc-gh-asawicki ! Have pushed changes for most of those suggestions and left a few comments on others. |
|
Thanks @sfc-gh-jcieslak , have updated that 🙂 |
sfc-gh-jcieslak
approved these changes
Sep 4, 2024
|
/ok-to-test sha=20808a006e04687aef5c5744d4b07a2e6201169f |
|
Integration tests failure for 20808a006e04687aef5c5744d4b07a2e6201169f |
sfc-gh-asawicki
approved these changes
Sep 5, 2024
sfc-gh-jmichalak
pushed a commit
that referenced
this pull request
Sep 19, 2024
🤖 I have created a release *beep* *boop* --- ## [0.96.0](v0.95.0...v0.96.0) (2024-09-18) Essential GA object readiness for V1: [link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD) ([Roadmap reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#preparing-essential-ga-objects-for-the-provider-v1)). :exclamation: Migration guide: [v0.95.0 -> v0.96.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0950--v0960) ### 🎉 **What's new:** * V1 redesign of resources and data sources * Row access policy ([#3066](#3066)) ([#3063](#3063)) * Resource monitor ([#3052](#3052)) ([#3064](#3064)) * Masking policy ([#3078](#3078)) ([#3083](#3083)) * SDK upgrades * External volume ([#3033](#3033)) * Authentication policy ([#2937](#2937)) ([#3068](#3068)) ([#3061](#3061)) ### 🔧 **Misc** * Clean up old test object helpers ([#3049](#3049)) * Add example of granting role to multiple objects ([#3047](#3047)) * Update readme and objects rework state ([#3046](#3046)) ### 🐛 **Bug fixes:** * Fix model grants ([#3070](#3070)) * Fix database show by and resource logic ([#3055](#3055)) * Fix default secondary roles option import ([#3041](#3041)) * Fix sweepers for warehouse and database ([#3057](#3057)) * Fix views permadiff ([#3079](#3079)) * Update v0.95.0 migration guide ([#3062](#3062)) Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the SDK for External Volumes. This is part of a series of PRs aimed at adding provider support for Iceberg tables.
References