feat: Add user parameters to resource

docs/resources/user.md

@@ -5,7 +5,7 @@ description: |-
 
 ---
 
-!> **V1 release candidate** This resource was reworked and is a release candidate for the V1. We do not expect significant changes in it before the V1. We will welcome any feedback and adjust the resource if needed. Any errors reported will be resolved with a higher priority. We encourage checking this resource out before the V1 release. Please follow the [migration guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0920--v0930) to use it.
+!> **V1 release candidate** This resource was reworked and is a release candidate for the V1. We do not expect significant changes in it before the V1. We will welcome any feedback and adjust the resource if needed. Any errors reported will be resolved with a higher priority. We encourage checking this resource out before the V1 release. Please follow the [migration guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v094x--v0950) to use it.
 
 # snowflake_user (Resource)
 

pkg/resources/user.go

@@ -308,7 +308,7 @@ func GetReadUserFunc(withExternalChangesMarking bool) schema.ReadContextFunc {
 
 		var defaultSecondaryRoles []string
 		if user.DefaultSecondaryRoles != nil && len(user.DefaultSecondaryRoles.Value) > 0 {
-			defaultSecondaryRoles = sdk.ParseCommaSeparatedStringArray(user.DefaultSecondaryRoles.Value, false)
+			defaultSecondaryRoles = sdk.ParseCommaSeparatedStringArray(user.DefaultSecondaryRoles.Value, true)
 		}
 		if err = d.Set("default_secondary_roles", defaultSecondaryRoles); err != nil {
 			return diag.FromErr(err)

pkg/sdk/parsers.go

@@ -32,7 +32,7 @@ func ParseCommaSeparatedStringArray(value string, trimQuotes bool) []string {
 	for i, item := range listItems {
 		trimmedListItems[i] = strings.TrimSpace(item)
 		if trimQuotes {
-			trimmedListItems[i] = strings.Trim(trimmedListItems[i], "'")
+			trimmedListItems[i] = strings.Trim(trimmedListItems[i], "'\"")
 		}
 	}
 	return trimmedListItems

pkg/sdk/parsers_test.go

@@ -61,11 +61,41 @@ func TestParseCommaSeparatedStringArray(t *testing.T) {
 			Result: []string{"one", "two", "three"},
 		},
 		{
-			Name:       "list without brackets - with quotes",
+			Name:       "list without brackets - with single quotes",
 			Value:      "'one','two','three'",
 			TrimQuotes: true,
 			Result:     []string{"one", "two", "three"},
 		},
+		{
+			Name:       "list without brackets - with double quotes",
+			Value:      `"one","two","three"`,
+			TrimQuotes: true,
+			Result:     []string{"one", "two", "three"},
+		},
+		{
+			Name:       "list with brackets - with double quotes",
+			Value:      `"one","two","three"`,
+			TrimQuotes: true,
+			Result:     []string{"one", "two", "three"},
+		},
+		{
+			Name:       "list with brackets - with double quotes, no trimming",
+			Value:      `"one","two","three"`,
+			TrimQuotes: false,
+			Result:     []string{"\"one\"", "\"two\"", "\"three\""},
+		},
+		{
+			Name:       "list with brackets - with double quotes",
+			Value:      `["one","two","three"]`,
+			TrimQuotes: true,
+			Result:     []string{"one", "two", "three"},
+		},
+		{
+			Name:       "multiple quote types",
+			Value:      `['"'one'"',"'two",'"three'"]`,
+			TrimQuotes: true,
+			Result:     []string{"one", "two", "three"},
+		},
 	}
 
 	for _, tc := range testCases {

templates/resources/user.md.tmpl

@@ -9,7 +9,7 @@ description: |-
 {{- end }}
 ---
 
-!> **V1 release candidate** This resource was reworked and is a release candidate for the V1. We do not expect significant changes in it before the V1. We will welcome any feedback and adjust the resource if needed. Any errors reported will be resolved with a higher priority. We encourage checking this resource out before the V1 release. Please follow the [migration guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0920--v0930) to use it.
+!> **V1 release candidate** This resource was reworked and is a release candidate for the V1. We do not expect significant changes in it before the V1. We will welcome any feedback and adjust the resource if needed. Any errors reported will be resolved with a higher priority. We encourage checking this resource out before the V1 release. Please follow the [migration guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v094x--v0950) to use it.
 
 # {{.Name}} ({{.Type}})