chore: add username_password auth test #2184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 08d90a987d5592dec8e52a2a6e1dca69c868b1b7 |
|
Integration tests failure for f57cb9edd742d69f4068bfcc371e9da20f0bad38 |
sfc-gh-asawicki
requested changes
Nov 13, 2023
| t.Helper() | ||
| return func(s *terraform.State) error { | ||
| rs, ok := s.RootModule().Resources[n] | ||
| if !ok { |
There was a problem hiding this comment.
Why not use testify/assert or testify/require instead?
| func TestAcc_ProviderUsernameAndPasswordAuth(t *testing.T) { | ||
| user := os.Getenv("SNOWFLAKE_USER") | ||
| if user == "" { | ||
| t.Skip("SNOWFLAKE_USER must be set") |
There was a problem hiding this comment.
Skip means this test will be treated as a success (currently). Should it be skipped or failed in such a case?
|
|
||
| var testAccProvider *schema.Provider | ||
|
|
||
| var testAccProtoV6ProviderFactories = map[string]func() (tfprotov6.ProviderServer, error){ |
There was a problem hiding this comment.
shouldn't this (+ testAccProvider variable and init function) be placed in some test_helper file? It seems like a variable that will be used in all new tests.
|
Superseded by #2551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a test case for username and password acceptance test, more tests to follow.