Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Escape Task SQL Statements #206

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Don't Escape Task SQL Statements #206

merged 3 commits into from
Jun 3, 2020

Conversation

chriskuchin
Copy link
Contributor

Escaping the SQL statement causes problems when the SQL statement requires quotes and other typically escaped things.

@chriskuchin chriskuchin requested a review from a team as a code owner June 3, 2020 20:45
@chriskuchin chriskuchin requested review from edulop91 and removed request for a team June 3, 2020 20:45
@chriskuchin chriskuchin changed the title Chrisk/fix task sql escaping Don't Escape Task SQL Statements Jun 3, 2020
@alldoami
Copy link
Contributor

alldoami commented Jun 3, 2020

Ran make test-acceptance-ci, and looks good.

@alldoami alldoami merged commit a4c5c84 into Snowflake-Labs:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alldoami alldoami alldoami approved these changes

@vcatalano vcatalano vcatalano approved these changes

@edulop91 edulop91 Awaiting requested review from edulop91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriskuchin @alldoami @vcatalano