-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for packages
, imports
, handler
and runtimeVersion
to snowflake_procedure
resource
#1516
Conversation
packages
, imports
, handler
and runtimeVersion
to snowflake_procedure
resourcepackages
, imports
, handler
and runtimeVersion
to snowflake_procedure
resource
- Whitespace in import strings can cause TF to believe that there are changes to the `snowflake_procedure` resource, as gaps in import names in the Snowflake response cause a space at the start of any imports after the first
Hey @sfc-gh-swinkler; would you mind approving this again please? I made a couple of changes that I hope will make the workflows that previously failed happy (docs and PR name). |
This is awesome! Thank you @badge. I just sat down to add support for this and after opening the PR saw your better version here :) thanks for contributing |
@sfc-gh-jhollan you're welcome! I think you might need to approve again for the workflows to run again?! |
👍 really keen to see support for deploying Python procedures via Terraform. Any idea when this may be available in the provider? Thanks! |
@sfc-gh-swinkler / @sfc-gh-jhollan is there anything that needs doing to this PR before it can be merged in for the next release? |
@sfc-gh-swinkler / @sfc-gh-jhollan when will this PR be merged? |
This PR adds support for the following optional parameters for
PROCEDURE
:packages
for Python and Java stored proceduresimports
again for Python and Javahandler
the target handler functionruntimeVersion
required for Python proceduresTest Plan
TestProcedureCreateWithOptionalParams
test inprocedure_test.go
has been updated to include the added optional parametersgetProcedure
func includes a statement, which doesn't make a huge amount of sense given that we are using a handler, but the equivalentgetPythonFunction
infunction_test.go
does too, so I assume this is ok