Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for packages, imports, handler and runtimeVersion to snowflake_procedure resource #1516

Merged
merged 6 commits into from
Mar 22, 2023

Conversation

badge
Copy link
Contributor

@badge badge commented Feb 6, 2023

This PR adds support for the following optional parameters for PROCEDURE:

  • packages for Python and Java stored procedures
  • imports again for Python and Java
  • handler the target handler function
  • runtimeVersion required for Python procedures

Test Plan

  • The TestProcedureCreateWithOptionalParams test in procedure_test.go has been updated to include the added optional parameters
    • The getProcedure func includes a statement, which doesn't make a huge amount of sense given that we are using a handler, but the equivalent getPythonFunction in function_test.go does too, so I assume this is ok
  • Tested that a local version of the provider with the new params successfully deploys a procedure to Snowflake 🎉

@badge badge changed the title Add support for packages, imports, handler and runtimeVersion to snowflake_procedure resource feat: Add support for packages, imports, handler and runtimeVersion to snowflake_procedure resource Feb 8, 2023
- Whitespace in import strings can cause TF to believe that
  there are changes to the `snowflake_procedure` resource,
  as gaps in import names in the Snowflake response cause
  a space at the start of any imports after the first
@badge
Copy link
Contributor Author

badge commented Feb 13, 2023

Hey @sfc-gh-swinkler; would you mind approving this again please? I made a couple of changes that I hope will make the workflows that previously failed happy (docs and PR name).

@sfc-gh-jhollan
Copy link

This is awesome! Thank you @badge. I just sat down to add support for this and after opening the PR saw your better version here :) thanks for contributing

@badge
Copy link
Contributor Author

badge commented Feb 15, 2023

@sfc-gh-jhollan you're welcome! I think you might need to approve again for the workflows to run again?!

@jagoodhand
Copy link

👍 really keen to see support for deploying Python procedures via Terraform. Any idea when this may be available in the provider?

Thanks!

@jagoodhand
Copy link

@sfc-gh-swinkler / @sfc-gh-jhollan is there anything that needs doing to this PR before it can be merged in for the next release?

@yo0824
Copy link

yo0824 commented Mar 20, 2023

@sfc-gh-swinkler / @sfc-gh-jhollan when will this PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants