fix: schema_name is optional to enable future pipe grant

[bennylu2]

• schema_name optional for future pipe grants
• Rename futurePipes to onFuture for consistency

Test Plan

make test
CGO_ENABLED=1 go test -race -coverprofile=coverage.txt -covermode=atomic  ./...
?       github.com/Snowflake-Labs/terraform-provider-snowflake  [no test files]
ok      github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/datasources  3.711s  coverage: 3.7% of statements
?       github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/db   [no test files]
?       github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/helpers      [no test files]
ok      github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/provider     2.318s  coverage: 25.5% of statements
ok      github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/resources    14.246s coverage: 48.2% of statements
ok      github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/snowflake    1.247s  coverage: 52.0% of statements
?       github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/testhelpers  [no test files]
ok      github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/validation   0.999s  coverage: 38.0% of statements
?       github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/version      [no test files]

References

#1219

[sfc-gh-swinkler]

Hello @bennylu2 there is a merge conflict which is a bit confusing for me to decipher since the variables are getting renamed, but the error messages are the same. Can you please rebase to main branch and fix the merge conflict?

<<<<<<< future-pipe-grants
	if (schemaName == "") && !onFuture {
		return errors.New("schema_name must be set unless on_future is true.")
	}
	if (pipeName == "") && !onFuture {
		return errors.New("pipe_name must be set unless on_future is true.")
=======
	if (pipeName == "") && !futurePipes {
		return errors.New("pipe_name must be set unless on_future is true")
	}
	if (pipeName != "") && futurePipes {
		return errors.New("pipe_name must be empty if on_future is true")
>>>>>>> main

[bennylu2]

@sfc-gh-swinkler rebased and ready for review

[sfc-gh-swinkler]

FYI you don't need to set schemaName to an empty string. Since you already declared it on line 94, and the default value of a type string is an empty string.

[sfc-gh-swinkler]

@bennylu2 im just going to go ahead an approve this, and fix the issues with go fmt and check docs to get it out in the latest release.

For future reference, you need to run go fmt ./... and also make docs since the schema changed.

[bennylu2]

@bennylu2 im just going to go ahead an approve this, and fix the issues with go fmt and check docs to get it out in the latest release.

For future reference, you need to run go fmt ./... and also make docs since the schema changed.

@sfc-gh-swinkler ah thanks, will keep in mind for future. I thought I did run make docs tho