Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop file format failure when does not exist #1399

Merged
merged 5 commits into from
Dec 7, 2022
Merged

fix: stop file format failure when does not exist #1399

merged 5 commits into from
Dec 7, 2022

Conversation

WobblyRobbly
Copy link
Contributor

@WobblyRobbly WobblyRobbly commented Dec 6, 2022

If a file format has been created vis the provider and the is subsequently deleted manually the plan refresh fails rather than removing the resource from the plan and recreating

Test Plan

  • [*] acceptance tests executed
  • [* ] unit test added

References

Fixes #1395
*

@WobblyRobbly WobblyRobbly changed the title fix: stop file format failure when does not exist #1395 fix: stop file format failure when does not exist Dec 6, 2022
@WobblyRobbly
Copy link
Contributor Author

my first PR so be gentle !!

@sfc-gh-swinkler
Copy link
Collaborator

this looks fine, except you need to run make docs. i will take care of it this time since need to get the latest release out. Appreciate your contribution!

@sfc-gh-swinkler sfc-gh-swinkler merged commit 3611ff5 into Snowflake-Labs:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Format plan refresh fails after manual deletion
3 participants