Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: task after dag support #1342

Merged
merged 21 commits into from
Nov 4, 2022
Merged

feat: task after dag support #1342

merged 21 commits into from
Nov 4, 2022

Conversation

sfc-gh-swinkler
Copy link
Collaborator

@sfc-gh-swinkler sfc-gh-swinkler commented Nov 4, 2022 •
edited
Loading

Tasks can have more than one predecessor (task DAG). So this feature changes the after tag to be a list of strings. https://docs.snowflake.com/en/user-guide/tasks-intro.html#dag-of-tasks

Test Plan

  • acceptance tests

@sfc-gh-swinkler sfc-gh-swinkler changed the title task after dag support feat: task after dag support Nov 4, 2022
github-actions[bot]
github-actions bot reviewed Nov 4, 2022
View reviewed changes
pkg/snowflake/task.go Outdated Show resolved Hide resolved
pkg/resources/task.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 75d6420695dd88142252b0f71bd8212e6d1fa417

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for b3470ab5f124f6c2e9af4e02c3a1abb6634fe702

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 93aa0441e06640c085a3b699901ba2be5fcf133e

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 6d33c7a875dae8098878fdbc2cbe4b27a635c68c

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for aac8b1348c77bc88acea44070bf709313bf70be4

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 6113170721b62db5f63b0f96e4df9bc825f25ede

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 8df7c3190f65e8c05846495a89d4093744a0ad90

github-actions[bot]
github-actions bot reviewed Nov 4, 2022
View reviewed changes
pkg/resources/task.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for f0df633b645590eb1012cdae7847201bfe45fc56

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for b2933ac2b15f374bcb33aa9ea710f2a6accd10d9

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 21e52975f6c60bc04b0e3a82184ca7f61cc642fa

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for c686c7603916684f854d75c27400c2304cbb4aa9

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 607ec8343309e798ccb5742ce74ac0f191bf6fbd

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 81ed9e54b3ff44b861d50caf15a422223833a1f6

github-actions[bot]
github-actions bot reviewed Nov 4, 2022
View reviewed changes
pkg/resources/task.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 3d26bf404aca3860a71e8d9b2d670cfcc65771f7

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for e90f84869da03d2c00c253d7516b15fe9e5911ed

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 560e23507cbbea60d3b244e3c635d4ec4f37bde5

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for dc8edd02365ec2b89a51feb78dd1875e77565ff4

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for f7f15e08062f113108daecfd29486347304350d1

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests failure for 288c7adb333f7cd6367bf97494ae23cbf9dee676

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Integration tests success for 9f3054b8f1c6084a86b59511d8c22f403b5ddcbc

@sfc-gh-swinkler sfc-gh-swinkler merged commit a117802 into main Nov 4, 2022
@sfc-gh-swinkler sfc-gh-swinkler deleted the task-after branch November 4, 2022 23:02
@snowflake-release-please snowflake-release-please bot mentioned this pull request Nov 4, 2022
Merged
@sfc-gh-swinkler sfc-gh-swinkler mentioned this pull request Nov 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-swinkler