feat: add failover groups #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pkg/resources/failover_group.go
Outdated
| currentObjectTypeList := d.Get("object_types").(*schema.Set).List() | ||
| if len(currentObjectTypeList) != len(objectTypes) { | ||
| log.Printf("[DEBUG] object types are different, current: %v, new: %v", currentObjectTypeList, objectTypes) | ||
| d.Set("object_types", objectTypes) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of d.Set is not checked (errcheck)
|
Integration tests failure for f6e6054c8b766196a2d975edbfe12806a30c3dce |
|
Integration tests success for 20577f852ef3afe353ac2e9fc61da654d9af3c3c |
|
Integration tests success for de413202696a6769f24209215bc44b251cae67e4 |
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new resource to manage failover groups
Test Plan
References