Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: typo on README #1172

Merged
merged 5 commits into from
Aug 31, 2022
Merged

docs: typo on README #1172

merged 5 commits into from
Aug 31, 2022

Conversation

senmm
Copy link
Contributor

@senmm senmm commented Aug 15, 2022

Fix a small typo.

@sfc-gh-swinkler
Copy link
Collaborator

can you please run make check-docs ?

@senmm
Copy link
Contributor Author

senmm commented Aug 24, 2022

@sfc-gh-swinkler Thank you for your message. I ran make check-docs and I found some files to need to fix. Could you please recheck this PR?

sfc-gh-swinkler
sfc-gh-swinkler approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@sfc-gh-swinkler sfc-gh-swinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-swinkler sfc-gh-swinkler merged commit dd72c8b into Snowflake-Labs:main Aug 31, 2022
@sfc-gh-swinkler
Copy link
Collaborator

thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@senmm @sfc-gh-swinkler