Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix pipe_grant doc #1091

Merged
merged 4 commits into from
Jul 11, 2022
Merged

docs: Fix pipe_grant doc #1091

merged 4 commits into from
Jul 11, 2022

Conversation

yohei1126
Copy link
Contributor

@yohei1126 yohei1126 commented Jun 30, 2022 •
edited
Loading

Test Plan

  • acceptance tests
  • …

References

@yohei1126 yohei1126 changed the title Fix pipe_grant doc docs: Fix pipe_grant doc Jun 30, 2022
@yohei1126 yohei1126 mentioned this pull request Jul 1, 2022
Closed
@sfc-gh-swinkler
Copy link
Collaborator

hello @yohei1126 thank you for your PR. can you please update your branch?

@yohei1126
Copy link
Contributor Author

@sfc-gh-swinkler done

@yohei1126
Copy link
Contributor Author

@sfc-gh-swinkler would you check this PR?

@sfc-gh-swinkler
Copy link
Collaborator

/ok-to-test sha=88397e2

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Integration tests success for 88397e2

@sfc-gh-swinkler sfc-gh-swinkler enabled auto-merge (squash) July 7, 2022 19:44
@sfc-gh-swinkler sfc-gh-swinkler disabled auto-merge July 7, 2022 19:45
@sfc-gh-swinkler sfc-gh-swinkler enabled auto-merge (rebase) July 7, 2022 19:45
@sfc-gh-swinkler sfc-gh-swinkler disabled auto-merge July 7, 2022 19:45
@sfc-gh-swinkler
Copy link
Collaborator

@yohei1126 hi, this looks good but can you please rebase for me?

@yohei1126
Copy link
Contributor Author

@sfc-gh-swinkler done

@sfc-gh-jalin
Copy link
Contributor

Sorry @yohei1126, could you rebase one more time? I was working on some other changes and merged them in before checking back on this PR

@yohei1126
Copy link
Contributor Author

done

@sfc-gh-jalin
Copy link
Contributor

/ok-to-test sha=066cb34

@github-actions
Copy link

Integration tests success for 066cb34

@sfc-gh-jalin sfc-gh-jalin merged commit ffa9392 into Snowflake-Labs:main Jul 11, 2022
@yohei1126 yohei1126 deleted the fix-pipe-doc branch July 12, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs for snowflake_pipe_grant show example with sequence_name
3 participants
@yohei1126 @sfc-gh-swinkler @sfc-gh-jalin