Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update go and docs package #1009

Merged
merged 28 commits into from
May 23, 2022
Merged

fix: Update go and docs package #1009

merged 28 commits into from
May 23, 2022

Conversation

alldoami
Copy link
Contributor

@alldoami alldoami commented May 18, 2022 •
edited
Loading

Removed https://github.com/chanzuckerberg/terraform-provider-snowflake/pull/1009/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L128, ran go get -u and go mod tidy.

Went through lint errors and fixed. Also deciphered https://github.com/reviewdog/reviewdog#exit-codes and updated the lint-ci command.

Removed all Exists functions because they are no longer used.

@github-actions
Copy link

Integration tests failure for 1741a5cc5a37b64a1faa981742fe472cbef8390f

@alldoami alldoami changed the title fix: Update go fix: Update go and docs package May 18, 2022
@alldoami alldoami requested a review from sfc-gh-jalin May 18, 2022 23:38
@github-actions
Copy link

Integration tests failure for 9be87d4ea0108b217f96c25f8519106fd50f55c6

@github-actions
Copy link

Integration tests failure for 0df9dae0dd3fe03ebfe5062416732262be6b4afa

@github-actions
Copy link

Integration tests failure for 6540967016b401bf9ff4467eccd72a5820d0342c

@github-actions
Copy link

Integration tests failure for bddc6ae0f9007a6880cf184bcddbecf6a3550b99

@github-actions
Copy link

Integration tests failure for 0ac3a35ff1c4f515113757b7d91321db2a26d000

@github-actions
Copy link

Integration tests failure for e40e4afc182445a84b9df2ec8f752b38e6a148e8

@github-actions
Copy link

Integration tests failure for 342bf71509e215b6abc38e4b2e98ca8dcd940184

@github-actions
Copy link

Integration tests failure for 561bb0b547ac168a5d9c86e5f7fc5c65900a6bc9

@github-actions
Copy link

Integration tests failure for 0778658688bd8a8dc604262a530058abc5e22a8d

@github-actions
Copy link

Integration tests failure for 93247e12257759760ccfe0d9ff46248fe7bec77d

@github-actions
Copy link

Integration tests failure for a0953a9c76ba6eee56758140b9d41f3f0d061095

@github-actions
Copy link

Integration tests failure for a3349a281b8e19cb2d8807d1f38b857127c53e9a

@github-actions
Copy link

Integration tests failure for daf4eb9441f2c31e1b54016f68ab09d3c80128c7

@github-actions
Copy link

Integration tests failure for 0d8444ed4ff5b3129e8711926504dc462e2c2b35

@github-actions
Copy link

Integration tests failure for e635aa73e4a0484f0c540824ca8590760f91dd4b

cziie
cziie reviewed May 20, 2022
View reviewed changes
pkg/resources/file_format.go Outdated
@@ -301,7 +301,8 @@ func FileFormat() *schema.Resource {
Read: ReadFileFormat,
Update: UpdateFileFormat,
Delete: DeleteFileFormat,
Exists: FileFormatExists,
//lintignore:R003
Exists: CheckFileFormat,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[tfproviderlint] reported by reviewdog 🐶
R003: resource should not include Exists function

pkg/resources/notification_integration.go Outdated
@@ -125,7 +125,8 @@ func NotificationIntegration() *schema.Resource {
Read: ReadNotificationIntegration,
Update: UpdateNotificationIntegration,
Delete: DeleteNotificationIntegration,
Exists: NotificationIntegrationExists,
//lintignore:R003
Exists: CheckNotificationIntegration,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[tfproviderlint] reported by reviewdog 🐶
R003: resource should not include Exists function

@github-actions
Copy link

Integration tests failure for 49f7d4f03e4faeeb0e1ad814f2d11c4b513ca1be

@github-actions
Copy link

Integration tests failure for 90c545d6de0a62b2d3844140e979a36e14b7891b

@github-actions
Copy link

Integration tests failure for 8856b90cb932adf7ba18cf5ab7122b75415a8959

@github-actions
Copy link

Integration tests failure for ea4ca5efcf038d988f5b225cad607dbc13b90fe7

@github-actions
Copy link

Integration tests success for 3eb5dcb61b0e2c5f01b8c5e6e6949edb2e0f7581

@github-actions
Copy link

Integration tests success for 2071b1d99e3f4c1a19b543de82f58966222bb385

@github-actions
Copy link

Integration tests success for 89e3ecca35870a843cddf533a062001f0643f51c

@github-actions
Copy link

Integration tests failure for 5c875a9ce67c606c7b2e81a7b0cb8cb7e670b778

@github-actions
Copy link

Integration tests failure for 40d8387443d3b063e8b921982661413dae538de0

@github-actions
Copy link

Integration tests success for 73d2abbf917f192e6e57f5a8354617630fd6f618

@alldoami alldoami merged commit 72c3180 into main May 23, 2022
@alldoami alldoami deleted the CDI-1-update-go-try branch May 23, 2022 23:32
This was referenced May 24, 2022
Merged
Merged
This was referenced Nov 1, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cziie cziie cziie left review comments

@sfc-gh-jalin sfc-gh-jalin Awaiting requested review from sfc-gh-jalin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alldoami @cziie @sfc-gh-jalin