Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add allowed values #1006

Merged
merged 23 commits into from
May 26, 2022
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
413162b
Add allowed_values field to the snowflake_tag resource
sfc-gh-kumaurya May 17, 2022
5dd57f0
Add allowed_values field to the snowflake_tag resource
sfc-gh-kumaurya May 17, 2022
4a6f354
Fixing doc and adding example for snowflake_tag resource
sfc-gh-kumaurya May 17, 2022
45aec4e
Fixing doc and adding example for snowflake_tag resource
sfc-gh-kumaurya May 17, 2022
8bd4e0e
testing allowed_values
sfc-gh-kumaurya May 17, 2022
ba38357
testing allowed_values
sfc-gh-kumaurya May 17, 2022
f6c9c10
testing allowed_values
sfc-gh-kumaurya May 17, 2022
60722d5
testing allowed_values
sfc-gh-kumaurya May 17, 2022
f1ea611
testing allowed_values
sfc-gh-kumaurya May 17, 2022
8f6cf9c
testing allowed_values
sfc-gh-kumaurya May 17, 2022
3bf5861
adding example usage for snowflake_tag resource
sfc-gh-kumaurya May 17, 2022
12d7e57
minor fixes
sfc-gh-kumaurya May 19, 2022
19665c1
Moving ListToSnowflakeString functions to helpers directory
sfc-gh-kumaurya May 19, 2022
9d33bfe
Moving ListToSnowflakeString functions to helpers directory
sfc-gh-kumaurya May 19, 2022
909288f
pull changes from snowflakelabs/terraform-provider-snowflake
sfc-gh-kumaurya May 24, 2022
c6d0d23
Merge branch 'Snowflake-Labs-main' into add_allowed_values
sfc-gh-kumaurya May 24, 2022
9302e1a
Updating with latest changes
sfc-gh-kumaurya May 25, 2022
8d892b0
Merge branch 'Snowflake-Labs-main' into add_allowed_values
sfc-gh-kumaurya May 25, 2022
239a98f
Updating import
sfc-gh-kumaurya May 25, 2022
fd8770c
Updating import for tag
sfc-gh-kumaurya May 25, 2022
92c16cc
Updating import
sfc-gh-kumaurya May 25, 2022
bc1b0d9
Updating acceptance tests of table annd tag for allowed_values
sfc-gh-kumaurya May 26, 2022
1ffdd57
Merge branch 'main' into add_allowed_values
sfc-gh-swinkler May 26, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
testing allowed_values
sfc-gh-kumaurya committed May 17, 2022
commit f6c9c10420df9a5ff793eaecf53190696d1e8c32
4 changes: 2 additions & 2 deletions pkg/resources/tag.go
Original file line number Diff line number Diff line change
@@ -266,8 +266,8 @@ func ReadTag(d *schema.ResourceData, meta interface{}) error {
return err
}

av := strings.ReplaceAll(t.AllowedValues.String, "\"", "")
av = strings.Replace(av, "[", "", 1)
// av := strings.ReplaceAll(t.AllowedValues.String, "\"", "")
av := strings.Replace(t.AllowedValues.String, "[", "", 1)
av = strings.TrimSuffix(av, "]")
// av = strings.ReplaceAll(av, "]", "")