Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]: snowflake_tag uses warehouse from v0.99.0 #3251

Closed
1 task
harukitake opened this issue Dec 6, 2024 · 2 comments
Closed
1 task

[Docs]: snowflake_tag uses warehouse from v0.99.0 #3251

harukitake opened this issue Dec 6, 2024 · 2 comments
Assignees
@sfc-gh-jmichalak
Labels
docs Used to mark issues with documentation remark/questions

Comments

@harukitake
Copy link

Company Name

No response

Object type(s)

resource:tag

Documentation Link

https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/tag

Description

Up to v0.98.0, snowflake_tag resource uses SHOW to get tag information, but in v0.99.0 snowflake_tag resource has changed to querying information_schema.
Provider users need to configure warehouse to use snowflake_tag resource.
Most resources don't require warehouse configuration, so I request to update migration guide.

References

No response

Would you like to implement a fix?

  • Yeah, I'll take it 😎
@harukitake harukitake added the docs Used to mark issues with documentation remark/questions label Dec 6, 2024
@sfc-gh-asawicki
Copy link
Collaborator

Hey @harukitake. Thanks for bringing it to our attention.

We will update the migration guide.

@sfc-gh-jmichalak sfc-gh-jmichalak mentioned this issue Dec 9, 2024
Merged
2 tasks
@sfc-gh-jmichalak sfc-gh-jmichalak self-assigned this Dec 9, 2024
sfc-gh-jmichalak added a commit that referenced this issue Dec 10, 2024
@sfc-gh-jmichalak
fix: Minor fixes 2 (#3230)
73b7e74 
<!-- Feel free to delete comments as you fill this in -->
- prove that using network policy with lowercase characters in oauth
integration fails in Snowflake
- update the migration guide regarding migrating provider configuration
- rename `datasource` to `data source`
- add missing examples and fix some examples in the docs
- add notes about missing fields (they will be done in SNOW-1844996)
- adjust documentation for provider configuration
- improve quoting with import and resource configuration examples
- some examples of replication and grants were not changed because they
show a nicer setup, IMO - can discuss about this
- add info about external changes not being detected for certain fields
or resource types
- change infobox format for some notes (`[!WARNING]` -> `!> Note`)
because it isn't rendered properly in the registry
- fix empty `using` in view masking policies
- add links to documentation of the referenced resources
- adjust enum validations to use `sdkValidation` with SDK converter
function instead of `StringInSlice`
- address
#3247
by improving the documentation
- update lists in `v1-preparations` files
<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [x] integration tests

## References

#3198

#3251
## TODO (next PRs):
- check the migration guide once again
@harukitake
Copy link
Author

https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#breaking-change-required-warehouse

I confirmed that the migration guide has updated.
It looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-jmichalak sfc-gh-jmichalak

Labels
docs Used to mark issues with documentation remark/questions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@harukitake @sfc-gh-asawicki @sfc-gh-jmichalak