Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Secret Validation change #3111

Merged
merged 3 commits into from
Oct 4, 2024
Merged

chore: Secret Validation change #3111

merged 3 commits into from
Oct 4, 2024

Conversation

sfc-gh-fbudzynski
Copy link
Collaborator

Changes

  • changed secret validation to use generated validation without manual adjustments
  • changed parsing StringArrays to use ParseCommaSeparatedStringArray()
  • removed known issue with ConflictingFields from sdk generator README
  • removed comments and replaced them with jira issues

@sfc-gh-fbudzynski sfc-gh-fbudzynski marked this pull request as ready for review October 3, 2024 13:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Integration tests failure for 1c09768bd0697746c0d1bac8e1cc4517c93576d3

sfc-gh-jmichalak
sfc-gh-jmichalak approved these changes Oct 4, 2024
View reviewed changes
pkg/sdk/testint/secrets_gen_integration_test.go
@@ -19,7 +19,7 @@ func TestInt_Secrets(t *testing.T) {

integrationId := testClientHelper().Ids.RandomAccountObjectIdentifier()

// "YYYY-MM-DD" or "YYYY-MM-DD HH-MI-SS" format has to be used, otherwise Snowflake returns error: "Invalid date/time format"
// "YYYY-MM-DD" or "YYYY-MM-DD HH:MI-SS" format has to be used, otherwise Snowflake returns error: "Invalid date/time format"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: just asking: shouldn't it be HH:MI:SS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, will fix this with next PR

pkg/sdk/testint/secrets_gen_integration_test.go
@@ -121,7 +120,7 @@ func TestInt_Secrets(t *testing.T) {
})
})

// regarding the https://docs.snowflake.com/en/sql-reference/sql/create-secret secret with empty oauth_scopes list should inherit scopes from security_integration, but it does not
// TODO [SNOW-1678756]: oauth_copes not inherited or not displayed correctly when not provided
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: oauth_scopes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will correct it with next Secret related PR

pkg/sdk/secrets_gen_test.go
opts.Set.SetForFlow.SetForOAuthClientCredentials = &SetForOAuthClientCredentials{OauthScopes: &OauthScopesList{[]ApiIntegrationScope{{Scope: "foo"}}}}
opts.Set.SetForFlow.SetForOAuthAuthorization = &SetForOAuthAuthorization{OauthRefreshToken: String("foo"), OauthRefreshTokenExpiryTime: String("bar")}
opts.Set.SetForFlow.SetForBasicAuthentication = &SetForBasicAuthentication{Username: String("foo"), Password: String("bar")}
opts.Set.SetForFlow.SetForGenericString = &SetForGenericString{SecretString: String("secret")}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: These 5 statements can be done like:

opts.Set.SetForFlow = &SetForFlow{
        SetForOAuthClientCredentials: &SetForOAuthClientCredentials{OauthScopes: &OauthScopesList{[]ApiIntegrationScope{{Scope: "foo"}}}}
        ...
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do this way next time and change it with next Secret PRs

@sfc-gh-fbudzynski sfc-gh-fbudzynski merged commit 666630e into main Oct 4, 2024
8 of 9 checks passed
@sfc-gh-fbudzynski sfc-gh-fbudzynski deleted the secret-conflicting-fields branch October 4, 2024 11:05
@snowflake-release-please snowflake-release-please bot mentioned this pull request Oct 4, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Oct 11, 2024
@snowflake-release-please
chore(main): release 0.97.0 (#3100)
561f78e 
🤖 I have created a release *beep* *boop*
---


##
[0.97.0](v0.96.0...v0.97.0)
(2024-10-10)


### 🎉 **What's new:**

* Add secret to sdk
([#3091](#3091))
([7430aee](7430aee))
* Add service user and legacy service user resources
([#3119](#3119))
([0e88e08](0e88e08))
* Handle all Task parameters in SDK
([#3103](#3103))
([08ae072](08ae072))
* Stream on external table resource
([#3122](#3122))
([d837341](d837341))
* Stream on table resource
([#3109](#3109))
([97fa9b4](97fa9b4))
* Tasks v1 readiness - SDK part
([#3086](#3086))
([0a77383](0a77383))
* Upgrade stream sdk
([#3105](#3105))
([ad5fa11](ad5fa11))


### 🔧 **Misc**

* Add pre check to each datasource
([#3065](#3065))
([560ab6b](560ab6b))
* Bump golang-ci lint to 1.61
([#3112](#3112))
([f23e085](f23e085))
* Secret Validation change
([#3111](#3111))
([666630e](666630e))


### 🐛 **Bug fixes:**

* Fix parsing text in view, check parenthesis in
ParseSchemaObjectIdentifierWithArguments
([#3102](#3102))
([b0a67e6](b0a67e6))
* Try to reproduce 2679 and 3117
([#3124](#3124))
([ccdbc30](ccdbc30))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-fbudzynski @sfc-gh-jcieslak @sfc-gh-jmichalak