Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download.sh breaks on zip-only releases #215

Closed
leftathome opened this issue Jun 19, 2020 · 0 comments · Fixed by #216
Closed

download.sh breaks on zip-only releases #215

leftathome opened this issue Jun 19, 2020 · 0 comments · Fixed by #216
Assignees
@ryanking
Labels
bug Used to mark issues with provider's incorrect behavior

Comments

@leftathome
Copy link

I'm cobbling together some CI pipelines that currently auto-download this plugin using the downloader. (This will change soon, but give me a break, I just got it all working!)

I was sure this decision would take more than a week to come back to haunt me, but here we are - the downloader seems to be failing in a Linux AMD64 container.

The script fails thusly:

chanzuckerberg/terraform-provider-snowflake debug http_download https://github.com/chanzuckerberg/terraform-provider-snowflake/releases/download/v0.13.2/terraform-provider-snowflake_0.13.2_linux_amd64.tar.gz
 chanzuckerberg/terraform-provider-snowflake debug http_download_curl received HTTP status 404

As of this writing, there is no downloadable .tar.gz artifact for release v0.13.2. But download.sh works like a champ on v0.13.0, e.g.:

curl https://raw.githubusercontent.com/chanzuckerberg/terraform-provider-snowflake/master/download.sh | bash -s -- -d -b $HOME/.terraform.d/plugins v0.13.0

By my reading of the situation, either the plugin release process should be generating tarballs on some platforms, or (probably easier) download.sh should be constructing .zip downloads in more situations.
@ryanking ryanking added the bug Used to mark issues with provider's incorrect behavior label Jun 22, 2020
@ryanking ryanking self-assigned this Jun 22, 2020
ryanking added a commit that referenced this issue Jun 23, 2020
@ryanking
[fix] download.sh
8978cc6 
Fix download.sh by specifying .zip and fixing the path to the checksums
file.

This broke with our changes to support releasing to the registry and
this should fix #215.
@ryanking ryanking mentioned this issue Jun 23, 2020
Merged
2 tasks
czimergebot pushed a commit that referenced this issue Jun 23, 2020
@ryanking
[fix] download.sh (#216)
58230c3 
Fix download.sh by specifying .zip and fixing the path to the checksums
file.

This broke with our changes to support releasing to the registry and
this should fix #215.

## Test Plan
* [x] acceptance tests
* [x] reproduce the problem with: `curl https://raw.githubusercontent.com/chanzuckerberg/terraform-provider-snowflake/master/download.sh | bash -s -- -d -b $HOME/.terraform.d/plugins v0.13.2
` and test the fix with `curl https://raw.githubusercontent.com/chanzuckerberg/terraform-provider-snowflake/ryanking/update_download.sh/download.sh | bash -s -- -d -b $HOME/.terraform.d/plugins v0.13.2`

## References
* Fixes #215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanking ryanking

Labels
bug Used to mark issues with provider's incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] download.sh Snowflake-Labs/terraform-provider-snowflake
2 participants
@ryanking @leftathome