-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"snowflake_database" "with_replication" { is not setting up the replication #2021
Comments
I am seeing this issue using 0.67.0 of the provider. My DB is created but the replication settings are not present. |
Also seeing this in 0.70.1 |
I am seeing this in 0.72.0. After reviewing the logs with the INFO level turned on, I found that only the CREATE DATABASE statement ran without any parameters for replication. No additional ALTER DATABASE statement was run to enable replication. |
Seeing this as well. It appears to have been introduced in 0.66.0 with the refactoring done in #1840. It looks like the replication config is now only considered for databases created from shares. A subsequent update to the database resource in TF (i.e., modify the replication_configuration) will cause the replication config to be created, but there is also a bug in the update path. It expects the |
I suspect this will be fixed by this recent PR? #2421 |
Hey @chrisluedtke. It should be fixed partly (the |
- Move replication config in create to the right place - Add show replication databases to the SDK - Add `FullyQualifiedName` to `ExternalIdentifier` References: #2021
🤖 I have created a release *beep* *boop* --- ## [0.87.0](v0.86.0...v0.87.0) (2024-02-28) ### 🎉 **What's new:** * Add network rule to the sdk ([#2526](#2526)) ([b379565](b379565)) * supports collation of table column ([#2496](#2496)) ([56771f1](56771f1)) ### 🔧 **Misc** * Clean up environment variables in tests and on CI ([#2543](#2543)) ([9a10cb1](9a10cb1)) * replace warning in new grant resources with info log ([#2521](#2521)) ([c3014b9](c3014b9)) ### 🐛 **Bug fixes:** * data retention days follow up ([#2566](#2566)) ([7aba384](7aba384)) * data retention time parameters ([#2502](#2502)) ([76abf21](76abf21)) * data retention time parameters follow-up ([#2530](#2530)) ([5544544](5544544)) * Demote warning to info and set volatility for procedures and functions ([#2567](#2567)) ([abaad7c](abaad7c)), closes [#2536](#2536) * Fix ACCOUNT PARAMETERS option failover group resource ([#2522](#2522)) ([61883f3](61883f3)), closes [#2517](#2517) * Fix failover group alter syntax and suppression for pipe statement ([#2562](#2562)) ([24d76c3](24d76c3)) * Fix few tests ([#2515](#2515)) ([a523a6b](a523a6b)) * Fix provider config hierarchy ([#2551](#2551)) ([677a12b](677a12b)) * Fix query_results in unsafe_execute resource ([#2512](#2512)) ([94ca158](94ca158)), closes [#2491](#2491) * Fix replication for database resource ([#2524](#2524)) ([767fbce](767fbce)), closes [#2021](#2021) * Fix show by id for external functions ([#2531](#2531)) ([d910a84](d910a84)), closes [#2528](#2528) * Fix various small problems ([#2552](#2552)) ([f558ce6](f558ce6)) * Granting database roles ([#2511](#2511)) ([dc27d64](dc27d64)), closes [#2402](#2402) * grants on external volumes ([#2538](#2538)) ([1de9a29](1de9a29)) * Handle old reference for table_id in table constraint resource ([#2558](#2558)) ([d1e8912](d1e8912)), closes [#2535](#2535) * loosen identifier field validation for account object identifiers ([#2564](#2564)) ([a5ed8cd](a5ed8cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Hey @sgupta-01 @jreslock @brandocomando @DustinMoriarty @snyker-nb @chrisluedtke. We have released the fix as part of v0.87.0 release. Please follow the migration guide during the update. Please confirm that the issue is resolved in the newest version. Thanks! |
Provider Version
0.69.0
Terraform Version
v1.5.5
Describe the bug
resource "snowflake_database" "with_replication" {
name = "testing_2"
comment = "test comment 2"
replication_configuration {
accounts = ["test_account1", "test_account_2"]
ignore_edition_check = true
}
}
is not setting up the replication it's creating db's but not the replicated one
Expected behavior
A clear and concise description of what you expected to happen.
Code samples and commands
Please add code examples and commands that were run to cause the problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: