Skip to content

Commit

Permalink
Add missing issue references
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-asawicki committed Sep 3, 2024
1 parent 3fca32a commit e9405fb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions pkg/resources/network_policy.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ func NetworkPolicy() *schema.Resource {
// The main issue lays in the old Terraform SDK and how its handling DiffSuppression and CustomizeDiff
// for complex types like Sets, Lists, and Maps. When every element of the Set is suppressed in custom diff,
// it returns true for d.HasChange anyway (it returns false for suppressed changes on primitive types like Number, Bool, String, etc.).
// TODO [SNOW-1648997]: address the above comment
ComputedIfAnyAttributeChanged(
networkPolicySchema,
ShowOutputAttributeName,
Expand Down
3 changes: 2 additions & 1 deletion pkg/resources/user.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ var userSchema = map[string]*schema.Schema{
Description: booleanStringFieldDescription("Specifies whether the user is disabled, which prevents logging in and aborts all the currently-running queries for the user."),
Default: BooleanDefault,
},
// TODO [SNOW-1649000]: consider handling external change if there is no config (or zero) for `days_to_expiry` and other similar attributes (what about this the other way around?)
"days_to_expiry": {
Type: schema.TypeInt,
Optional: true,
Expand Down Expand Up @@ -199,7 +200,7 @@ func User() *schema.Resource {

CustomizeDiff: customdiff.All(
// TODO [SNOW-1629468 - next pr]: test "default_role", "default_secondary_roles"
// TODO [SNOW-TODO]: "default_secondary_roles" have to stay commented out because of how the SDKv2 handles diff suppressions and custom diffs for sets
// TODO [SNOW-1648997]: "default_secondary_roles" have to stay commented out because of how the SDKv2 handles diff suppressions and custom diffs for sets
ComputedIfAnyAttributeChanged(userSchema, ShowOutputAttributeName, "password", "login_name", "display_name", "first_name", "last_name", "email", "must_change_password", "disabled", "days_to_expiry", "mins_to_unlock", "default_warehouse", "default_namespace", "default_role", "mins_to_bypass_mfa", "rsa_public_key", "rsa_public_key_2", "comment", "disable_mfa"),
ComputedIfAnyAttributeChanged(userParametersSchema, ParametersAttributeName, collections.Map(sdk.AsStringList(sdk.AllUserParameters), strings.ToLower)...),
ComputedIfAnyAttributeChanged(userSchema, FullyQualifiedNameAttributeName, "name"),
Expand Down

0 comments on commit e9405fb

Please sign in to comment.