fix: external_table headers order doesn't matter (#731)

docs/resources/external_function.md

@@ -51,7 +51,7 @@ resource "snowflake_external_function" "test_ext_func" {
 - **comment** (String) A description of the external function.
 - **compression** (String) If specified, the JSON payload is compressed when sent from Snowflake to the proxy service, and when sent back from the proxy service to Snowflake.
 - **context_headers** (List of String) Binds Snowflake context function results to HTTP headers.
-- **header** (Block List) Allows users to specify key-value metadata that is sent with every request as HTTP headers. (see [below for nested schema](#nestedblock--header))
+- **header** (Block Set) Allows users to specify key-value metadata that is sent with every request as HTTP headers. (see [below for nested schema](#nestedblock--header))
 - **id** (String) The ID of this resource.
 - **max_batch_rows** (Number) This specifies the maximum number of rows in each batch sent to the proxy service.
 - **null_input_behavior** (String) Specifies the behavior of the external function when called with null inputs.

pkg/resources/external_function.go

@@ -105,7 +105,7 @@ var externalFunctionSchema = map[string]*schema.Schema{
 		Description: "The name of the API integration object that should be used to authenticate the call to the proxy service.",
 	},
 	"header": {
-		Type:        schema.TypeList,
+		Type:        schema.TypeSet,
 		Optional:    true,
 		ForceNew:    true,
 		Description: "Allows users to specify key-value metadata that is sent with every request as HTTP headers.",
@@ -114,11 +114,13 @@ var externalFunctionSchema = map[string]*schema.Schema{
 				"name": {
 					Type:        schema.TypeString,
 					Required:    true,
+					ForceNew:    true,
 					Description: "Header name",
 				},
 				"value": {
 					Type:        schema.TypeString,
 					Required:    true,
+					ForceNew:    true,
 					Description: "Header value",
 				},
 			},
@@ -277,7 +279,7 @@ func CreateExternalFunction(d *schema.ResourceData, meta interface{}) error {
 
 	if _, ok := d.GetOk("header"); ok {
 		headers := []map[string]string{}
-		for _, header := range d.Get("header").([]interface{}) {
+		for _, header := range d.Get("header").(*schema.Set).List() {
 			headerDef := map[string]string{}
 			for key, val := range header.(map[string]interface{}) {
 				headerDef[key] = val.(string)

pkg/resources/external_function_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/chanzuckerberg/terraform-provider-snowflake/pkg/provider"
 	"github.com/chanzuckerberg/terraform-provider-snowflake/pkg/resources"
 	. "github.com/chanzuckerberg/terraform-provider-snowflake/pkg/testhelpers"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/stretchr/testify/require"
 )
 
@@ -99,7 +100,7 @@ func TestExternalFunctionRead(t *testing.T) {
 		r.Equal("data", test_func_args["name"].(string))
 		r.Equal("varchar", test_func_args["type"].(string))
 
-		headers := d.Get("header").([]interface{})
+		headers := d.Get("header").(*schema.Set).List()
 		r.Len(headers, 1)
 		test_func_headers := headers[0].(map[string]interface{})
 		r.Len(test_func_headers, 2)
@@ -134,7 +135,7 @@ func TestExternalFunctionReadReturnTypeVariant(t *testing.T) {
 		r.Equal("data", test_func_args["name"].(string))
 		r.Equal("varchar", test_func_args["type"].(string))
 
-		headers := d.Get("header").([]interface{})
+		headers := d.Get("header").(*schema.Set).List()
 		r.Len(headers, 1)
 		test_func_headers := headers[0].(map[string]interface{})
 		r.Len(test_func_headers, 2)