Fix tests

Snowflake-Labs · Jul 5, 2024 · c2d6fa7 · c2d6fa7
1 parent c4fa972
commit c2d6fa7
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/pkg/sdk/parsers.go b/pkg/sdk/parsers.go
@@ -32,7 +32,7 @@ func ParseCommaSeparatedStringArray(value string, trimQuotes bool) []string {
 	for i, item := range listItems {
 		trimmedListItems[i] = strings.TrimSpace(item)
 		if trimQuotes {
-			trimmedListItems[i] = strings.Trim(item, "'")
+			trimmedListItems[i] = strings.Trim(trimmedListItems[i], "'")
 		}
 	}
 	return trimmedListItems

diff --git a/pkg/sdk/parsers_test.go b/pkg/sdk/parsers_test.go
@@ -28,6 +28,18 @@ func TestParseCommaSeparatedStringArray(t *testing.T) {
 			Value:  "[one]",
 			Result: []string{"one"},
 		},
+		{
+			Name:       "one element in list - with quotes",
+			Value:      "['one']",
+			TrimQuotes: true,
+			Result:     []string{"one"},
+		},
+		{
+			Name:       "multiple elements in list - with quotes",
+			Value:      "['one', 'two', 'three']",
+			TrimQuotes: true,
+			Result:     []string{"one", "two", "three"},
+		},
 		{
 			Name:   "multiple elements in list",
 			Value:  "[one, two, three]",
@@ -46,7 +58,13 @@ func TestParseCommaSeparatedStringArray(t *testing.T) {
 		{
 			Name:   "list without brackets",
 			Value:  "one,two,three",
-			Result: []string{},
+			Result: []string{"one", "two", "three"},
+		},
+		{
+			Name:       "list without brackets - with quotes",
+			Value:      "'one','two','three'",
+			TrimQuotes: true,
+			Result:     []string{"one", "two", "three"},
 		},
 	}