Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-swinkler committed Feb 12, 2024
1 parent 8f022a6 commit 6ec3403
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
16 changes: 8 additions & 8 deletions MIGRATION_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@ This document is meant to help you migrate your Terraform config to the new newe
describe deprecations or breaking changes and help you to change your configuration to keep the same (or similar) behavior
across different versions.

## vX.XX.X -> vY.YY.Y

### Migration from old (grant) resources to new ones

In recent changes, we introduced a new grant resources to replace the old ones.
To aid with the migration, we wrote a guide to show one of the possible ways to migrate deprecated resources to their new counter-parts.
As the guide is more general and applies to every version (and provider), we moved it [here](./docs/technical-documentation/resource_migration.md).

## v0.85.0 ➞ v0.86.0
### snowflake_table_constraint resource changes

Expand All @@ -22,6 +14,14 @@ It is noted as a behavior change but in some way it is not; with the previous im

We will consider adding `NOT NULL` back because it can be set by `ALTER COLUMN columnX SET NOT NULL`, but first we want to revisit the whole resource design.

## vX.XX.X -> v0.85.0

### Migration from old (grant) resources to new ones

In recent changes, we introduced a new grant resources to replace the old ones.
To aid with the migration, we wrote a guide to show one of the possible ways to migrate deprecated resources to their new counter-parts.
As the guide is more general and applies to every version (and provider), we moved it [here](./docs/technical-documentation/resource_migration.md).

### snowflake_procedure resource changes
#### *(deprecation)* return_behavior
`return_behavior` parameter is deprecated because it is also deprecated in the Snowflake API.
Expand Down
3 changes: 2 additions & 1 deletion pkg/sdk/testint/procedures_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,8 @@ def filter_by_role(session, table_name, role):
argument := sdk.NewProcedureArgumentRequest("id", sdk.DataTypeVARCHAR)
request := sdk.NewCreateForSQLProcedureRequest(id, *returns, definition).
WithOrReplace(sdk.Bool(true)).
WithNullInputBehavior(sdk.NullInputBehaviorPointer(sdk.NullInputBehaviorReturnNullInput)).
// SNOW-1051627 todo: uncomment once null input behavior working again
// WithNullInputBehavior(sdk.NullInputBehaviorPointer(sdk.NullInputBehaviorReturnNullInput)).
WithArguments([]sdk.ProcedureArgumentRequest{*argument})
err := client.Procedures.CreateForSQL(ctx, request)
require.NoError(t, err)
Expand Down

0 comments on commit 6ec3403

Please sign in to comment.