Review suggestions

Snowflake-Labs · Oct 17, 2024 · 6be59db · 6be59db
1 parent 7c9137e
commit 6be59db
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/pkg/resources/tag.go b/pkg/resources/tag.go
@@ -47,7 +47,7 @@ var tagSchema = map[string]*schema.Schema{
 	FullyQualifiedNameAttributeName: schemas.FullyQualifiedNameSchema,
 }
 
-// TODO: remove after rework of external table, materialized view, stage and table
+// TODO(SNOW-1348114, SNOW-1348110, SNOW-1348355, SNOW-1348353): remove after rework of external table, materialized view, stage and table
 var tagReferenceSchema = &schema.Schema{
 	Type:        schema.TypeList,
 	Optional:    true,

diff --git a/pkg/sdk/testint/applications_integration_test.go b/pkg/sdk/testint/applications_integration_test.go
@@ -251,7 +251,7 @@ func TestInt_Applications(t *testing.T) {
 		require.NoError(t, err)
 		assertApplication(t, id, applicationPackage.Name, version, patch, "")
 
-		// TODO: adjust after this is fixed on Snowflake side
+		// TODO(SNOW-1746420): adjust after this is fixed on Snowflake side
 		_, err = client.SystemFunctions.GetTag(ctx, tagTest.ID(), id, sdk.ObjectTypeApplication)
 		require.ErrorContains(t, err, "391801 (0A000): SQL compilation error: Object tagging not supported for object type APPLICATION")
 

diff --git a/pkg/sdk/testint/databases_integration_test.go b/pkg/sdk/testint/databases_integration_test.go
@@ -609,6 +609,9 @@ func TestInt_DatabasesAlter(t *testing.T) {
 				},
 			})
 			require.NoError(t, err)
+
+			_, err = client.SystemFunctions.GetTag(ctx, tagTest.ID(), databaseTest.ID(), sdk.ObjectTypeDatabase)
+			require.Error(t, err)
 		})
 
 		t.Run(fmt.Sprintf("Database: %s - swap with another database", testCase.DatabaseType), func(t *testing.T) {