changes after review

Snowflake-Labs · Feb 15, 2024 · 24bb9dd · 24bb9dd
1 parent 316554a
commit 24bb9dd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pkg/resources/testdata/TestAcc_GrantDatabaseRole/share/test.tf b/pkg/resources/testdata/TestAcc_GrantDatabaseRole/share/test.tf
@@ -11,7 +11,7 @@ variable "database" {
 }
 
 resource "snowflake_database" "test" {
-  name     = var.database
+  name = var.database
 }
 
 resource "snowflake_database_role" "test" {
@@ -24,9 +24,9 @@ resource "snowflake_share" "test" {
 }
 
 resource "snowflake_grant_privileges_to_share" "test" {
-  privileges = ["USAGE"]
+  privileges  = ["USAGE"]
   on_database = snowflake_database.test.name
-  to_share = snowflake_share.test.name
+  to_share    = snowflake_share.test.name
 }
 
 resource "snowflake_grant_database_role" "test" {

diff --git a/pkg/sdk/grants.go b/pkg/sdk/grants.go
@@ -223,6 +223,7 @@ func (row grantRow) convert() *Grant {
 	grantTo := ObjectType(strings.ReplaceAll(row.GrantTo, "_", " "))
 	var granteeName AccountObjectIdentifier
 	if grantedTo == ObjectTypeShare {
+		// TODO(SNOW-1058419): Change this logic during identifiers rework
 		parts := strings.Split(row.GranteeName, ".")
 		switch {
 		case len(parts) == 1: