Fix dbshell's client_session_keep_alive and passcode_in_password options

Snowflake-Labs · Dec 16, 2023 · 224962a · 224962a
1 parent 4ccfa65
commit 224962a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,9 @@
   dictionary of the `DATABASES` setting instead of `'private_key'`. This is
   now the documented pattern in the README.
 
+* Fixed `dbshell` crash if using the `client_session_keep_alive` or
+  `passcode_in_password` options.
+
 ## 4.2 beta 1 - 2023-04-11
 
 * Added support for `JSONField`.

diff --git a/django_snowflake/client.py b/django_snowflake/client.py
@@ -34,15 +34,15 @@ def settings_to_cmd_args_env(cls, settings_dict, parameters):
         if authenticator:
             args += ['--authenticator', authenticator]
         if client_session_keep_alive:
-            args += ['--client-session-keep-alive', client_session_keep_alive]
+            args += ['--client-session-keep-alive']
         if dbname:
             args += ['-d', dbname]
         if host:
             args += ['-h', host]
         if passcode:
             args += ['--mfa-passcode', passcode]
         if passcode_in_password:
-            args += ['--mfa-passcode-in-password', passcode_in_password]
+            args += ['--mfa-passcode-in-password']
         if private_key_file:
             args += ['--private-key-path', private_key_file]
         if role: