-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage client copy move methods & fix threading when downloading blobs #153
base: main
Are you sure you want to change the base?
Conversation
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be done in an easier manner. Check comments
destination_blob = self._get_blob_client(blob_path=destination_blob_path) | ||
|
||
destination_blob.start_copy_from_url(source_blob.url) | ||
return destination_blob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you should return here what start_copy_from_url returns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do that, but it only returns a dictionary of current copy properties.
If we'd like to check progress, we need the blob_client object
destination_blob.start_copy_from_url(source_blob.url) | ||
return destination_blob | ||
|
||
def copy_blob( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd suggest using example from MS here
And remove async parameter, as this operation is always async.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the MS example, it doesn't seem they wait for the operation to complete?
Can we be certain the operation is complete when copied_blob.get_blob_properties()
is called?
No description provided.