Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing property documentation #146

Merged
merged 4 commits into from
Oct 2, 2021
Merged

Conversation

KeyboardRage
Copy link
Contributor

The interaction received from Discord also includes an application_id field.

The interaction received from Discord also includes an `application_id` field.
@KeyboardRage KeyboardRage requested a review from Snazzah as a code owner October 1, 2021 20:17
Copy link
Owner

@Snazzah Snazzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Tests need to be updated to account for the new property
  2. This should also be added to PingRequestData, DMMessageComponentRequestData, GuildMessageComponentRequestData, DMCommandAutocompleteRequestData and GuildCommandAutocompleteRequestData

@Snazzah Snazzah added semver: patch PRs that contain bugfixes and will be on the next patch release type: documentation Improvements or additions to documentation labels Oct 1, 2021
`application_id` is also sent with the interaction
Added missing `application_id` property
Added missing `application_id` properties
@KeyboardRage
Copy link
Contributor Author

  1. Tests need to be updated to account for the new property
  2. This should also be added to PingRequestData, DMMessageComponentRequestData, GuildMessageComponentRequestData, DMCommandAutocompleteRequestData and GuildCommandAutocompleteRequestData

Added to tests, not sure if I got it all though.
Also added the property to the mentioned types.

@Snazzah Snazzah merged commit f4fd2cc into Snazzah:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch PRs that contain bugfixes and will be on the next patch release type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants