Remove the dependency on java.util.Optional because it requires Android API level 24 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atn1990
approved these changes
Jul 1, 2021
bholmes-sc-zz
approved these changes
Jul 1, 2021
jb-gcx
added a commit
to jb-gcx/snapchat-djinni
that referenced
this pull request
Jul 8, 2024
…re-cpp-interface Add waitFor to djinni::Future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It prevents us from using the Outcome<> type on older Android devices.
There is another Optional type provided by Guava. However using that also complicates our dependencies.
Since providing the result and error as optionals is not essential, I decide to simply remove this and encourage the end user to use
resultOr()anderrorOrNull()instead.If you really want optional, it's also easy to achieve with the
match()function, but I will leave this to the user code as it is easier to know what is available in user code than in the support library.