Make clang-tidy happier #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,7 @@ struct EnumUsageRecord final { | |||
| std::unordered_set<color> s; | |||
| std::unordered_map<color, color> m; | |||
|
|
|||
| //NOLINTNEXTLINE(google-explicit-constructor) | |||
There was a problem hiding this comment.
explciit only applies to single parameter constructors. why do we need this here?
There was a problem hiding this comment.
changed codegen, only add NOLINT for records with exactly 1 field.
bholmes-sc-zz
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change by Eric Ulevik:
clang-tidy complains about single-argument constructors not being explicit. Changing the constructors to be explicit would require more code changes, so disable using NOLINT.
clang-tidy complains about not using ' = default;', this was fixed.