Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imported enum types #16

Merged
merged 4 commits into from
Oct 14, 2021
Merged

Fix imported enum types #16

merged 4 commits into from
Oct 14, 2021

Conversation

finalpatch
Copy link
Contributor

Imported enum types should have int32_t type in wasm rather than const val&

bholmes-sc-zz
bholmes-sc-zz approved these changes Oct 14, 2021
View reviewed changes
Copy link

@bholmes-sc-zz bholmes-sc-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a change to the example generated sources that reflects this?

@finalpatch
Copy link
Contributor Author

is there a change to the example generated sources that reflects this?

I'm adding a new unit test

@finalpatch finalpatch merged commit 8d9e410 into master Oct 14, 2021
@finalpatch finalpatch deleted the lf/fix-yaml-enum branch October 14, 2021 23:50
@tongyuze tongyuze mentioned this pull request Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bholmes-sc-zz bholmes-sc-zz bholmes-sc-zz approved these changes

@benjaminhollissc benjaminhollissc Awaiting requested review from benjaminhollissc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@finalpatch @bholmes-sc-zz @li-feng-sc