simple_layer example: Handle 0 width/height in configure correctly #482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wlr-layer-shell-unstable
protocol says:While the wording doesn't make it clear, I think it's reasonable to assume it's talking about each dimension separately - the word "dimension" isn't plural, and there's legitimate use cases for this behavior (e.g. scrolling compositors like niri).
Relevent issue: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/155 (about xdg-shell not layer-shell, the wording comes from there)
This can also be written as:
or plain ifs, which might be a little bit more readable, but I feel like using and encouraging
NonZeroU32
is more idiomatic and flexible. It's not clear what's the MSRV policy, but I avoidedNonZero
since it's pretty new (rust1.79.0
).