Restrict SimpleGlobal bindings to our max API version #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial fix for the way SimpleGlobal binds to the latest version offered by the server instead of the latest version the client understands, which causes errors (usually leading to crashes) when a server actually uses the later version and sends an event we don't know about.
|
@wash2 could we make it into patch release on v0.16.x branch? It affects wezterm from what I understood since they haven't updated yet and I'm not sure whether they will. |
|
The CI failures are not relevant if it matters. |
i509VCB
reviewed
Sep 16, 2023
kchibisov
approved these changes
Sep 16, 2023
|
Should we increment the version to 0.16.1 in this PR? |
|
@wash2 in the separate. |
wash2
approved these changes
Sep 18, 2023
|
Just a minor note -- it seems that the 0.16.1 tag was never pushed to this repo (though that version has been published on crates.io and docs.rs successfully). |
|
Ok the tag is pushed now |
|
Cheers, thanks! |
This was referenced Dec 7, 2023
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Mar 19, 2024
### Changed - Updated smithay-client-toolkit to resolve issue described in Smithay/client-toolkit#406 (#20). https://github.com/AndreasBackx/waycorner/actions/runs/8351084763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for the way SimpleGlobal binds to the latest version offered by the server instead of the latest version the client understands, which causes errors (usually leading to crashes) when a server actually uses the later version and sends an event we don't know about.
This fixes crashes in a number of clients using SCTK-0.16 on compositors supporting the newest wayland surface APIs (to be precise, any that send a
preferred_buffer_scaleevent).