Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make header-fields case-insensitive #681

Merged

Conversation

patrickjahns
Copy link
Member

In order to comply with rfc7230 headerfields are now parsed case-insensitive and retrieved case-insensitive

fixes #672

@hreintke
Copy link
Contributor

hreintke commented Apr 4, 2016

@patrickjahns :
I agree with the update/patch.
Formally there is backward compatibility issue. Applications which rely on the (incorrect) case sensitivity will not work anymore.
What is your opinion on this ?

@patrickjahns
Copy link
Member Author

@hreintke
To be honest I didn't think of backward compatibility issues.
Generally any existing code would still work as before, no matter the spelling (i.e. getHeader("Content-Length"); getHeader("content-length"); getHeader("cOnTeNt-LeNgTh"); will all return the same.

While header names are case-insensitive, the values of the header fields are case-sensitive and thus nothing has changed from the previous behavior.

Is there any planned release notes for the upcoming Sming release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: The header field name is case-insensitive but is not processed as such.
3 participants