Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/getMaxDuty #2902

Closed
wants to merge 7 commits into from
Closed

Fix/getMaxDuty #2902

wants to merge 7 commits into from

Conversation

pljakobs
Copy link
Contributor

  • moved the getMaxDuty() implementation to the class implementations for all architectures. Before that, for esp32c3, it would always return 0, despite maxduty being correctly set.

Copy link

what-the-diff bot commented Oct 30, 2024

PR Summary

  • Introduction of Max Duty Cycle
    This update includes a new method called getMaxDuty() to the HardwarePWM classes in Esp32, Esp8266, and Rp2040 cores. It simply means we have added a new feature that allows us to find out the maximum duty cycle.

  • Header File Updated
    The header file HardwarePWM.h has been updated to just declare getMaxDuty(). This helps us maintain a cleaner and more organized code structure.

  • Basic Function in Host Core
    A basic function of getMaxDuty() has been implemented in the Host core, which currently returns 0. Though it seems simple, it's the base for more complex operations that will be built upon it in the future.

@pljakobs pljakobs marked this pull request as draft October 30, 2024 16:41
@pljakobs pljakobs closed this Oct 30, 2024
@pljakobs pljakobs deleted the fix/getMaxDuty branch October 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant