Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rp2040 cyw43 firmware build bug #2854

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jul 5, 2024

Bad Rp2040 cyw43 firmware build bug, introduced in #2804.

Also ensure builds work with previous 10.3.1 toolchain.

Copy link

what-the-diff bot commented Jul 5, 2024

PR Summary

  • Improved File Size Calculation Function
    The write_chunk function, which is important for understanding the size of each file in our project, was adjusted to compute the file size more accurately. This could help us manage our storage usage better.

  • Adjusted Linker Flags with Compiler Version Consideration
    The settings for our compiler, currently known as 'Linker Flags' (LDFLAGS), have been updated to include -Wl,--no-warn-rwx-segments. This update will only be applied when our compiler's main version isn't equal to 10. This adjustment enables more stable compilations of our code, providing a smoother development process.

@mikee47 mikee47 force-pushed the fix/rp2040-cyw43-bug branch from 1f40278 to 5330790 Compare July 5, 2024 07:55
@slaff slaff added this to the 5.2.0 milestone Jul 5, 2024
@slaff slaff merged commit 68ecf10 into SmingHub:develop Jul 5, 2024
48 checks passed
@mikee47 mikee47 deleted the fix/rp2040-cyw43-bug branch July 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants