Minor websocket client issues #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
changed the title
mikee47
force-pushed
the
fix/websocket-client-errors
branch
from
960b450 to
d0af2b6
Compare
mikee47
changed the title
mikee47
changed the title
|
@mikee47 can you rebase this PR? |
Default doesn't agree with `WebsocketClient` sample, should be 8000
mikee47
force-pushed
the
fix/websocket-client-errors
branch
from
d0af2b6 to
dd317eb
Compare
slaff
added
3.5 - Approved - Waiting for CI results
and removed
3.5 - Approved - Waiting for CI results
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few fixes for websockets I seem to have kicking about.
wsservertool missing port argument handling, default is 8000 not 9999Check return value from http
connect()I can force this to fail by calling 'connect' twice in succession, though I do notice a disparity here. If the http connection is 'processing' then
WebsocketClient::connectreturnsfalse; however,HttpClientConnection::connectreturnstruein this situation.TODO:
Document all the variousOutside scope of this PR. See Handling TCP connection errors #2829connectmethods and clarify meaning of return value.