Refactor spi flash code #2810
Merged
Refactor spi flash code #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB. `flashmem_get_first_free_block_address` is obsolete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tidies up the flash memory code and adds the
flash_addr_tandflash_sector_ttypes. In paricular,flash_addr_tdefines flash addresses asuintptr_trather thanuint32_t. The primary reason for this is that host builds emulate flash addresses using memory pointers.The main flash interface definitions are in
Sming/Components/arch_driver/src/include/flashmem.h. The arch header filesesp_spi_flash.hinclude this after any arch-specific definitions.Other changes:
flashmem_get_first_free_block_address- serves no purpose since partitions were introduced.flashmem_get_size_type()SPIFlashInfostructure returned fromflashmem_get_info()is now common to all architectures, although the fields within may have different values. This means it no longer reflects the actual in-flash structure for Esp8266. Applications should never rely on this anyway, so not considered a breaking change.