Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hwconfig-list output formatting #2645

Merged
merged 1 commit into from
May 26, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented May 26, 2023

I'm getting this:

[mike@fedora Basic_Blink]$ make hwconfig-list

Basic_Blink: Invoking 'hwconfig-list' for Esp8266 (debug) architecture
Available configurations: \n   spiffs-2m                 /home/mike/sandboxes/sming2/Sming/spiffs-2m.hw \n   spiffs-two-roms           /home/mike/sandboxes/sming2/Sming/Arch/Esp8266/spiffs-two-roms.hw \n   spiffs                    /home/mike/sandboxes/sming2/Sming/spiffs.hw \n   standard-4m               /home/mike/sandboxes/sming2/Sming/standard-4m.hw \n * standard                  /home/mike/sandboxes/sming2/Sming/Arch/Esp8266/standard.hw \n   two-rom-mode              /home/mike/sandboxes/sming2/Sming/Arch/Esp8266/two-rom-mode.hw

Should be like this:

[mike@fedora Basic_Blink]$ make hwconfig-list

Basic_Blink: Invoking 'hwconfig-list' for Esp8266 (debug) architecture
Available configurations: 
   spiffs-2m                 /home/mike/sandboxes/sming2/Sming/spiffs-2m.hw 
   spiffs-two-roms           /home/mike/sandboxes/sming2/Sming/Arch/Esp8266/spiffs-two-roms.hw 
   spiffs                    /home/mike/sandboxes/sming2/Sming/spiffs.hw 
   standard-4m               /home/mike/sandboxes/sming2/Sming/standard-4m.hw 
 * standard                  /home/mike/sandboxes/sming2/Sming/Arch/Esp8266/standard.hw 
   two-rom-mode              /home/mike/sandboxes/sming2/Sming/Arch/Esp8266/two-rom-mode.hw

@what-the-diff
Copy link

what-the-diff bot commented May 26, 2023

PR Summary

  • Change printf to echo command
    The printf command was updated to use the echo command for displaying output.
  • Add newline character
    A newline character is now added at the end of the output string, ensuring output messages appear on separate lines.

@slaff slaff added this to the 5.0.0 milestone May 26, 2023
@slaff slaff merged commit 47eddab into SmingHub:develop May 26, 2023
@mikee47 mikee47 deleted the fix/hwconfig-list branch May 28, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants