Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rp2040 fix IRAM_ATTR usage #2644

Merged
merged 1 commit into from
May 26, 2023
Merged

Rp2040 fix IRAM_ATTR usage #2644

merged 1 commit into from
May 26, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented May 26, 2023

Function attributes should only be in implementation (rather than declaration) but cannot be in both.

Rp2040 fix IRAM_ATTR usage
f98fa10 
Should only be in implementation (rather than declaration) but cannot be in both.
@what-the-diff
Copy link

what-the-diff bot commented May 26, 2023

PR Summary

  • Removed IRAM_ATTR attribute from hw_timer1_attach_interrupt function
    The attribute was removed to improve code accuracy and functionality.
  • Added IRAM_ATTR attribute to hw timer 1 enable function
    This addition allows proper functioning of interrupts for the specific hardware timer used in Sming RTOS.

@slaff slaff added this to the 5.0.0 milestone May 26, 2023
@slaff slaff merged commit c01e326 into SmingHub:develop May 26, 2023
@mikee47 mikee47 deleted the fix/rp2040-iram branch May 28, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff